Skip to content

Conversation

@jackwilsdon
Copy link

@jackwilsdon jackwilsdon commented Feb 6, 2019

It appears that goimports and this repository have diverged again since #347, as they now disagree on this code;

import "github.com/dgrijalva/jwt-go"

golangci-lint wants this;

import jwt "github.com/dgrijalva/jwt-go"

Whereas goimports is fine with this;

import "github.com/dgrijalva/jwt-go"

It appears that a change was made to goimports which treats jwt-go and jwt as the same, by ignoring any characters after non-identifier runes (see golang/tools@cb89afa).

This PR simply updates golang.org/x/tools (and therefore goimports) such that the tools line up again at their latest versions.

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2019

CLA assistant check
All committers have signed the CLA.

@jirfag jirfag closed this in 81cf487 Feb 11, 2019
@jirfag
Copy link
Contributor

jirfag commented Feb 11, 2019

hi, thank you!
because of conflicts I've updated it myself

markus-wa added a commit to markus-wa/demoinfocs-golang that referenced this pull request Jun 9, 2019
@markus-wa
Copy link
Contributor

@jirfag upgrading to 1.16.0 doesn't seem to fix this.

Installing golangci-lint: https://travis-ci.org/markus-wa/demoinfocs-golang/jobs/543361295#L527
Error: https://travis-ci.org/markus-wa/demoinfocs-golang/jobs/543361295#L555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants