Update gochecknoglobals to support version exception (#601)

liamawhite · jirfag · commit e1a7422dd5d2 · 2019-09-09T16:42:51.000+03:00
See leighmcculloch/gochecknoglobals@7c3491d
diff --git a/pkg/golinters/gochecknoglobals.go b/pkg/golinters/gochecknoglobals.go
@@ -61,7 +61,7 @@ func (lint Gochecknoglobals) checkFile(f *ast.File, fset *token.FileSet) []resul
 }
 
 func isWhitelisted(i *ast.Ident) bool {
-	return i.Name == "_" || looksLikeError(i)
+	return i.Name == "_" || i.Name == "version" || looksLikeError(i)
 }
 
 // looksLikeError returns true if the AST identifier starts

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ func (lint Gochecknoglobals) checkFile(f ast.File, fset token.FileSet) []resul`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`func isWhitelisted(i *ast.Ident) bool {`
`64`		`- return i.Name == "_" \|\| looksLikeError(i)`
	`64`	`+ return i.Name == "_" \|\| i.Name == "version" \|\| looksLikeError(i)`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`// looksLikeError returns true if the AST identifier starts`