Relates #381, #367: cleanup docs and warn if unparam algo was configured

Author: jirfag

.golangci.example.yml

@@ -128,10 +128,6 @@ linters-settings:
     # with golangci-lint call it on a directory with the changed file.
     check-exported: false
   unparam:
-    # call graph construction algorithm (cha, rta). In general, use cha for libraries,
-    # and rta for programs with main packages. Default is cha.
-    algo: cha
-
     # Inspect exported functions, default is false. Set to true if no external program/library imports your code.
     # XXX: if you enable this setting, unparam will report a lot of false-positives in text editors:
     # if it's called for subdir of a project it can't find external interfaces. All text editor integrations

README.md

@@ -651,10 +651,6 @@ linters-settings:
     # with golangci-lint call it on a directory with the changed file.
     check-exported: false
   unparam:
-    # call graph construction algorithm (cha, rta). In general, use cha for libraries,
-    # and rta for programs with main packages. Default is cha.
-    algo: cha
-
     # Inspect exported functions, default is false. Set to true if no external program/library imports your code.
     # XXX: if you enable this setting, unparam will report a lot of false-positives in text editors:
     # if it's called for subdir of a project it can't find external interfaces. All text editor integrations

pkg/golinters/unparam.go

@@ -22,6 +22,10 @@ func (Unparam) Desc() string {
 func (lint Unparam) Run(ctx context.Context, lintCtx *linter.Context) ([]result.Issue, error) {
 	us := &lintCtx.Settings().Unparam
 
+	if us.Algo != "cha" {
+		lintCtx.Log.Warnf("`linters-settings.unparam.algo` isn't supported by the newest `unparam`")
+	}
+
 	c := &check.Checker{}
 	c.CheckExportedFuncs(us.CheckExported)
 	c.Packages(lintCtx.Packages)