result/processors: treat all non-Go source as special autogenerated files

kortschak · web-flow · commit 33fe87b2a56f · 2020-12-11T17:07:28.000+10:30
Prior to this change golangci-lint would attempt to follow //line
directives into generation description files unless they were in a small
set of fake files used by goyacc. Now we consider all non-Go source as
special.
diff --git a/pkg/result/processors/autogenerated_exclude.go b/pkg/result/processors/autogenerated_exclude.go
@@ -43,8 +43,8 @@ func (p *AutogeneratedExclude) Process(issues []result.Issue) ([]result.Issue, e
 
 func isSpecialAutogeneratedFile(filePath string) bool {
 	fileName := filepath.Base(filePath)
-	// fake files to which //line points to for goyacc generated files
-	return fileName == "yacctab" || fileName == "yaccpar" || fileName == "NONE"
+	// fake files or generation definitions to which //line points to for generated files
+	return filepath.Ext(fileName) != ".go"
 }
 
 func (p *AutogeneratedExclude) shouldPassIssue(i *result.Issue) (bool, error) {

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,8 @@ func (p *AutogeneratedExclude) Process(issues []result.Issue) ([]result.Issue, e`
`43`	`43`
`44`	`44`	`func isSpecialAutogeneratedFile(filePath string) bool {`
`45`	`45`	`fileName := filepath.Base(filePath)`
`46`		`- // fake files to which //line points to for goyacc generated files`
`47`		`- return fileName == "yacctab" \|\| fileName == "yaccpar" \|\| fileName == "NONE"`
	`46`	`+ // fake files or generation definitions to which //line points to for generated files`
	`47`	`+ return filepath.Ext(fileName) != ".go"`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`func (p AutogeneratedExclude) shouldPassIssue(i result.Issue) (bool, error) {`