Skip to content

Commit 2b966e1

Browse files
committed
feat: deprecate AnalyzerPlugin
1 parent c208db8 commit 2b966e1

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

pkg/lint/lintersdb/custom_linters.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,18 +85,18 @@ func (m *Manager) getAnalyzerPlugin(path string, settings any) ([]*analysis.Anal
8585
return nil, err
8686
}
8787

88-
analyzers, err := lookupPlugin(plug, settings)
88+
analyzers, err := m.lookupPlugin(plug, settings)
8989
if err != nil {
9090
return nil, fmt.Errorf("lookup plugin %s: %w", path, err)
9191
}
9292

9393
return analyzers, nil
9494
}
9595

96-
func lookupPlugin(plug *plugin.Plugin, settings any) ([]*analysis.Analyzer, error) {
96+
func (m *Manager) lookupPlugin(plug *plugin.Plugin, settings any) ([]*analysis.Analyzer, error) {
9797
symbol, err := plug.Lookup("New")
9898
if err != nil {
99-
analyzers, errP := lookupAnalyzerPlugin(plug)
99+
analyzers, errP := m.lookupAnalyzerPlugin(plug)
100100
if err != nil {
101101
return nil, errors.Join(err, errP)
102102
}
@@ -113,12 +113,14 @@ func lookupPlugin(plug *plugin.Plugin, settings any) ([]*analysis.Analyzer, erro
113113
return constructor(settings)
114114
}
115115

116-
func lookupAnalyzerPlugin(plug *plugin.Plugin) ([]*analysis.Analyzer, error) {
116+
func (m *Manager) lookupAnalyzerPlugin(plug *plugin.Plugin) ([]*analysis.Analyzer, error) {
117117
symbol, err := plug.Lookup("AnalyzerPlugin")
118118
if err != nil {
119119
return nil, err
120120
}
121121

122+
m.log.Warnf("plugin: 'AnalyzerPlugin' plugins are deprecated, please the new plugin signature: https://golangci-lint.run/contributing/new-linters/#create-a-plugin")
123+
122124
analyzerPlugin, ok := symbol.(AnalyzerPlugin)
123125
if !ok {
124126
return nil, fmt.Errorf("plugin does not abide by 'AnalyzerPlugin' interface: %T", symbol)

0 commit comments

Comments
 (0)