Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only-new-issues flag is not working as expected #523

Closed
gane5hvarma opened this issue Jul 26, 2022 · 2 comments · Fixed by #1029
Closed

only-new-issues flag is not working as expected #523

gane5hvarma opened this issue Jul 26, 2022 · 2 comments · Fixed by #1029
Labels
question Further information is requested

Comments

@gane5hvarma
Copy link

So i have raised a pr with lint issues like multiline and type check. When this flag only-new-issues is added, its not checking the linting errors which are introduced. When removed this flag, the lint error is being caught
Here is my github action file

name: golangci-lint
permissions:
  contents: read
on:
  push:
    branches: [ main ]
  pull_request:
    branches: [ main ]
jobs:
  golangci-lint:
    strategy:
      matrix:
        go-version: [ 1.18.x ]
        os: [ ubuntu-latest ]
    runs-on: ${{ matrix.os }}
    steps:
    - name: Install Go
      uses: actions/setup-go@v3
      with:
        go-version: ${{ matrix.go-version }}
    - name: Checkout code
      uses: actions/checkout@v3
    - name: golangci-lint
      uses: golangci/[email protected]
      with:
        version: latest
        args: --timeout 5m --out-${NO_FUTURE}format colored-line-number
        only-new-issues: true
        skip-cache: true
@ldez ldez added the question Further information is requested label Aug 7, 2022
@jacobbednarz
Copy link

i don't think only-new-issues works with pushes; only pull requests as it cannot compare only the change introduced in the PR. i generally only run golanglint-ci on the pull_request event to handle this.

@ldez
Copy link
Member

ldez commented Apr 29, 2024

Fixed by #1029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
3 participants