Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for context based Refactoring #329

Closed
imkernel opened this issue Jul 12, 2020 · 3 comments
Closed

Support for context based Refactoring #329

imkernel opened this issue Jul 12, 2020 · 3 comments

Comments

@imkernel
Copy link

Is your feature request related to a problem? Please describe.
vscode is the most used editor by golang survey and currently it lacks the refactoring feature.

Describe the solution you'd like

  1. When a variable, function or any identifier is selected there should be an option to refactor the variable, the result should be that all the references to this identifier in the current context is refactored
  2. When a piece of code is selected there should be an option to extract it as a function

Describe alternatives you've considered
vim-go is an alternative editor plugin that has this functionality.

Additional context
This issue was tracked in microsoft vscode repo, the issue is microsoft/vscode-go#1173

@stamblerre
Copy link
Contributor

The issue you linked above was resolved. The features you describe are supported via these commands: https://github.com/golang/vscode-go/blob/master/docs/features.md#refactor. These features do not work with Go modules, but we are adding support for them in gopls, and they will be available in gopls/v0.4.4: golang/go#37170.

@imkernel
Copy link
Author

@stamblerre should this issue be closed then?

@stamblerre
Copy link
Contributor

Yep, closing.

@golang golang locked and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants