Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to run tests in background by default #3154

Open
leep-frog opened this issue Feb 2, 2024 · 3 comments · May be fixed by #3155
Open

Add option to run tests in background by default #3154

leep-frog opened this issue Feb 2, 2024 · 3 comments · May be fixed by #3155
Labels
FeatureRequest go-test issues related to go test support (test output, test explorer, ...)

Comments

@leep-frog
Copy link

Is your feature request related to a problem? Please describe.

This extension defaults to opening the output tab in the panel whenever a go test is run. This behavior should be configurable for a few reasons:

  • When the panel automatically opens (via outputChannel.show()), the terminal sometimes doesn't open fully (and instead does split screen). I'd prefer to update my keybinding for go.test.package to run go.test.package and then call toggleMaximizedPanel (using multi-command) to ensure the output tab always opens in full screen
  • I have tests that take a while and I want to stay in my editor while tests run
  • I have tests that I know work and I just want to see the coverage report in my code editor

Describe the solution you'd like

I think there are two approaches:

  1. Provide supplementary commands for all test commands (e.g. go.test.package and go.test.packageAsync/Background)
  2. Allow test commands to accept a keybinding args object that allows individual keybindings to specify background behavior (and possibly other testConfig in the future).

Describe alternatives you've considered

I can use the multi-command extension to run go tests, then close the panel, then open the maximized panel, but that is inconsistent (without a long delay), and is a bad user experience

Additional context
Add any other context or screenshots about the feature request here.

@gopherbot gopherbot added this to the Untriaged milestone Feb 2, 2024
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/567995 mentions this issue: allow args.background parameter for go.test.* commands

@hyangah
Copy link
Contributor

hyangah commented May 29, 2024

We hope to deprecate the old UI (the test output channel) in favor of the test explorer UI. (#2044)

It looks like VSCode's testing.openTesting setting for the new UI is similar to what you want. How about using the setting instead of inventing a new knob that is going to be deprecated? Its default is openOnTestStart which matches the current behavior of the old UI's test output channel. What do you think?

@hyangah hyangah added the go-test issues related to go test support (test output, test explorer, ...) label May 29, 2024
@leep-frog
Copy link
Author

leep-frog commented Jun 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest go-test issues related to go test support (test output, test explorer, ...)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants