Skip to content

Commit 1c36262

Browse files
committed
src/goDebugConfiguration: show warning that port is being used
This change needs to go in after the revert lands. Updates #1729 Change-Id: I4ea882b69894143e7bc5353ca54b11112631cdf9 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/346270 Trust: Suzy Mueller <[email protected]> Run-TryBot: Suzy Mueller <[email protected]> TryBot-Result: kokoro <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
1 parent 09d4bbe commit 1c36262

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/goDebugConfiguration.ts

+6
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,12 @@ export class GoDebugConfigurationProvider implements vscode.DebugConfigurationPr
158158
// for local mode, default to dlv-dap.
159159
debugConfiguration['debugAdapter'] = debugConfiguration['mode'] !== 'remote' ? 'dlv-dap' : 'legacy';
160160
}
161+
if (debugConfiguration['debugAdapter'] === 'dlv-dap' && debugConfiguration['port']) {
162+
this.showWarning(
163+
'ignorePortUsedInDlvDapWarning',
164+
"`port` is used with the 'dlv-dap' debugAdapter to support [launching the debug adapter server externally](https://github.com/golang/vscode-go/blob/master/docs/debugging.md#running-debugee-externally). Remove 'host' and 'port' from your launch.json if you are not launching a DAP server."
165+
);
166+
}
161167
if (debugConfiguration['debugAdapter'] === 'dlv-dap' && debugConfiguration['mode'] === 'remote') {
162168
this.showWarning(
163169
'ignoreDlvDAPInRemoteModeWarning',

0 commit comments

Comments
 (0)