From d27d783e9900769dda64625ffff01997434b037e Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Wed, 4 May 2022 10:10:00 -0400 Subject: [PATCH] cmd/godoc: expand skips in TestWeb After CL 403534, another TestWeb failure was observed in https://build.golang.org/log/24cca44e99d848317a6bb73b6d15528b500e5643. This change expands the skips to try to cover more of the cases where cmd/godoc might hang. For golang/go#50014. Change-Id: If3f08da69a68dc00c399b89ffb2c4f049114aeb6 Reviewed-on: https://go-review.googlesource.com/c/tools/+/403849 Auto-Submit: Bryan Mills Reviewed-by: Dmitri Shuralyov Run-TryBot: Bryan Mills Reviewed-by: Dmitri Shuralyov gopls-CI: kokoro TryBot-Result: Gopher Robot --- cmd/godoc/godoc_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/godoc/godoc_test.go b/cmd/godoc/godoc_test.go index 227fc897729..4eb341af1e1 100644 --- a/cmd/godoc/godoc_test.go +++ b/cmd/godoc/godoc_test.go @@ -96,7 +96,7 @@ func waitForSearchReady(t *testing.T, cmd *exec.Cmd, addr string) { 2*time.Minute, false) if err := <-ch; err != nil { - t.Fatal(err) + t.Skipf("skipping due to https://go.dev/issue/50014: %v", err) } } @@ -111,7 +111,7 @@ func waitUntilScanComplete(t *testing.T, addr string) { true, ) if err := <-ch; err != nil { - t.Fatal(err) + t.Skipf("skipping due to https://go.dev/issue/50014: %v", err) } }