Skip to content

Commit 031fc75

Browse files
committed
gopls/internal/regtest/bench: don't run the iwl test with -short
The new InitialWorkspaceLoad benchmark relies on a memstats command that does not exist in the released version of gopls (v0.11.0). We're configuring x/benchmarks to run with -short, so use this to guard against breaking the benchmark suite with this new test. Change-Id: I64e673fca793c51bd17d0245330543402fd86ec8 Reviewed-on: https://go-review.googlesource.com/c/tools/+/473677 Reviewed-by: Alan Donovan <[email protected]> gopls-CI: kokoro <[email protected]> Run-TryBot: Robert Findley <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent f477bf4 commit 031fc75

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

gopls/internal/regtest/bench/iwl_test.go

+5
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ import (
1616
// BenchmarkInitialWorkspaceLoad benchmarks the initial workspace load time for
1717
// a new editing session.
1818
func BenchmarkInitialWorkspaceLoad(b *testing.B) {
19+
if testing.Short() {
20+
// TODO(rfindley): remove this skip once the released gopls version
21+
// supports the memstats command.
22+
b.Skip("temporarily skipping as baseline gopls versions do not support the memstats command")
23+
}
1924
tests := []struct {
2025
repo string
2126
file string

0 commit comments

Comments
 (0)