From 9c2f3a21352d1ff4e47776534e3f334b39ec0183 Mon Sep 17 00:00:00 2001 From: Mauri de Souza Meneguzzo Date: Thu, 9 May 2024 19:08:14 +0000 Subject: [PATCH] cmd/gotext: fix segfault in extract & rewrite commands If extract or rewrite are called with no arguments it results in a segmentation fault, since we dereference the out flag that was not defined for these commands. Fixes golang/go#62697 Change-Id: I697943b7c221431d0361bcec74c18183f6e141ea GitHub-Last-Rev: 313ddfad2b9a43d4fbaa875fa4dd3110dcf38083 GitHub-Pull-Request: golang/text#46 Reviewed-on: https://go-review.googlesource.com/c/text/+/529255 Reviewed-by: Marcel van Lohuizen Auto-Submit: Ian Lance Taylor Reviewed-by: Ian Lance Taylor LUCI-TryBot-Result: Go LUCI Reviewed-by: Dmitri Shuralyov --- cmd/gotext/main.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/cmd/gotext/main.go b/cmd/gotext/main.go index ed0f7eca..5171eb15 100644 --- a/cmd/gotext/main.go +++ b/cmd/gotext/main.go @@ -48,11 +48,18 @@ func config() (*pipeline.Config, error) { if err != nil { return nil, wrap(err, "invalid srclang") } + + // Use a default value since rewrite and extract don't have an out flag. + genFile := "" + if out != nil { + genFile = *out + } + return &pipeline.Config{ SourceLanguage: tag, Supported: getLangs(), TranslationsPattern: `messages\.(.*)\.json$`, - GenFile: *out, + GenFile: genFile, Dir: *dir, }, nil }