Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syscall: TestSyscallAllocations/SyscallN failures #70327

Closed
gopherbot opened this issue Nov 13, 2024 · 10 comments
Closed

syscall: TestSyscallAllocations/SyscallN failures #70327

gopherbot opened this issue Nov 13, 2024 · 10 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.24

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Nov 13, 2024 •
edited by mknyszek
Loading 

#!watchflakes
default <- pkg == "syscall" && test ~ `TestSyscallAllocations/Syscall`

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestSyscallAllocations/SyscallN
    syscall_windows_test.go:256: allocs = 1, want 0
--- FAIL: TestSyscallAllocations/SyscallN (0.00s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 13, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "syscall" && test == "TestSyscallAllocations/SyscallN"
2024-11-13 19:57 gotip-windows-amd64-longtest go@26e10103 syscall.TestSyscallAllocations/SyscallN (log) 
=== RUN   TestSyscallAllocations/SyscallN
    syscall_windows_test.go:256: allocs = 1, want 0
--- FAIL: TestSyscallAllocations/SyscallN (0.00s)

— watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Nov 13, 2024
@mknyszek
Copy link
Contributor

CC @qmuntal since this is a new test. It's possible it's flaky and just catching background allocations from other sources. It may need more isolation to de-flake.

@mknyszek mknyszek added this to the Go1.24 milestone Nov 13, 2024
@mknyszek mknyszek mentioned this issue Nov 13, 2024
Open
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "syscall" && test ~ `TestSyscallAllocations/Syscall`
2024-11-14 17:25 gotip-windows-amd64-race go@cce90c1e syscall.TestSyscallAllocations/SyscallN (log) 
=== RUN   TestSyscallAllocations/SyscallN
    syscall_windows_test.go:256: allocs = 7, want 0
--- FAIL: TestSyscallAllocations/SyscallN (0.01s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "syscall" && test ~ `TestSyscallAllocations/Syscall`
2024-11-14 18:20 gotip-windows-amd64-race go@672a53de syscall.TestSyscallAllocations/SyscallN (log) 
=== RUN   TestSyscallAllocations/SyscallN
    syscall_windows_test.go:256: allocs = 6, want 0
--- FAIL: TestSyscallAllocations/SyscallN (0.01s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "syscall" && test ~ `TestSyscallAllocations/Syscall`
2024-11-18 17:29 gotip-windows-386 go@5ec14579 syscall.TestSyscallAllocations/SyscallN (log) 
=== RUN   TestSyscallAllocations/SyscallN
    syscall_windows_test.go:256: allocs = 5, want 0
--- FAIL: TestSyscallAllocations/SyscallN (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "syscall" && test ~ `TestSyscallAllocations/Syscall`
2024-11-18 19:09 gotip-windows-386 go@80344887 syscall.TestSyscallAllocations/SyscallN (log) 
=== RUN   TestSyscallAllocations/SyscallN
    syscall_windows_test.go:256: allocs = 3, want 0
--- FAIL: TestSyscallAllocations/SyscallN (0.01s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "syscall" && test ~ `TestSyscallAllocations/Syscall`
2024-11-18 20:30 gotip-windows-386 go@008904ab syscall.TestSyscallAllocations/SyscallN (log) 
=== RUN   TestSyscallAllocations/SyscallN
    syscall_windows_test.go:256: allocs = 3, want 0
--- FAIL: TestSyscallAllocations/SyscallN (0.00s)
2024-11-18 20:35 gotip-windows-amd64-race go@083045f9 syscall.TestSyscallAllocations/SyscallN (log) 
=== RUN   TestSyscallAllocations/SyscallN
    syscall_windows_test.go:256: allocs = 5, want 0
--- FAIL: TestSyscallAllocations/SyscallN (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "syscall" && test ~ `TestSyscallAllocations/Syscall`
2024-11-20 11:12 gotip-windows-386 go@606a0bd9 syscall.TestSyscallAllocations/SyscallN (log) 
=== RUN   TestSyscallAllocations/SyscallN
    syscall_windows_test.go:256: allocs = 5, want 0
--- FAIL: TestSyscallAllocations/SyscallN (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/630136 mentions this issue: syscall: do not run TestSyscallAllocations in parallel with other tests

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/630137 mentions this issue: testing: panic in AllocsPerRun if parallel tests are running

@github-project-automation github-project-automation bot moved this from Todo to Done in Go Compiler / Runtime Nov 20, 2024
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 20, 2024
@rsc rsc mentioned this issue Nov 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Go Compiler / Runtime
Status: Done
Test Flakes
Status: Done
Milestone
Go1.24
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot