x/tools/cmd/goimports: confusing error message when file contains CRLF

[abitrolly]

Go version

go version go1.23.3 windows/amd64

Output of go env in your module/workspace:

set GO111MODULE=
  set GOARCH=amd64
  set GOBIN=
  set GOCACHE=C:\Users\runneradmin\AppData\Local\go-build
  set GOENV=C:\Users\runneradmin\AppData\Roaming\go\env
  set GOEXE=.exe
  set GOEXPERIMENT=
  set GOFLAGS=
  set GOHOSTARCH=amd64
  set GOHOSTOS=windows
  set GOINSECURE=
  set GOMODCACHE=C:\Users\runneradmin\go\pkg\mod
  set GONOPROXY=
  set GONOSUMDB=
  set GOOS=windows
  set GOPATH=C:\Users\runneradmin\go
  set GOPRIVATE=
  set GOPROXY=https://proxy.golang.org,direct
  set GOROOT=C:\hostedtoolcache\windows\go\1.23.3\x64
  set GOSUMDB=sum.golang.org
  set GOTMPDIR=
  set GOTOOLCHAIN=auto
  set GOTOOLDIR=C:\hostedtoolcache\windows\go\1.23.3\x64\pkg\tool\windows_amd64
  set GOVCS=
  set GOVERSION=go1.23.3
  set GODEBUG=
  set GOTELEMETRY=local
  set GOTELEMETRYDIR=C:\Users\runneradmin\AppData\Roaming\go\telemetry
  set GCCGO=gccgo
  set GOAMD64=v1
  set AR=ar
  set CC=gcc
  set CXX=g++
  set CGO_ENABLED=1
  set GOMOD=D:\a\sflags\sflags\go.mod
  set GOWORK=
  set CGO_CFLAGS=-O2 -g
  set CGO_CPPFLAGS=
  set CGO_CXXFLAGS=-O2 -g
  set CGO_FFLAGS=-O2 -g
  set CGO_LDFLAGS=-O2 -g
  set PKG_CONFIG=pkg-config
  set GOGCCFLAGS=-m64 -mthreads -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\RUNNER~1\AppData\Local\Temp\go-build1760277560=/tmp/go-build -gno-record-gcc-switches

What did you do?

Run golangci-lint which invokes goimports on Windows machine.

https://github.com/urfave/sflags/actions/runs/11786526137/job/32829983012

Other reports are visible from golangci/golangci-lint#580

What did you see happen?

cmd\genvalues\main.go:1: File is not `goimports`-ed (goimports)

What did you expect to see?

cmd\genvalues\main.go:1: File contains CRLF linefeeds (goimports)

[gabyhelp]

Related Issues

• x/tools/gopls: autoimport doesn't work properly in VS Code when using CRLF line endings #47200 (closed)
• x/tools/cmd/goimports: line directive can cause file corruption #51119
• x/tools/cmd/goimports: adds flag control to delete extra blank lines before grouping #43193
• x/tools/cmd/goimports: lost line between package and import statements in output #26921
• x/tools/cmd/goimports: Spurious newlines #21101 (closed)
• x/tools/gopls: format_on_save_new_file (govim) test flaky #36772 (closed)
• x/tools/cmd/goimports: inserts unexpected blank space after an inline comment #26246 (closed)
• cmd/go: document Git setup to preserve go.mod line endings on Windows #31870 (closed)
• x/tools/cmd/goimports: truncates input file despite no -w flag #28270 (closed)
• cmd/go: go list starts the Package.Error.Err field with a newline #36762 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/627215 mentions this issue: internal/imports: keep the crlf if exist

[cherrymui]

There have been a number of discussions about CRLF. I couldn't find exactly what the conclusion was. The CL above replaces \n to \r\n as long as there exists a single \r\n, which I don't think is the right behavior.

cc @golang/tools-team

[Zxilly]

I don't have a complaint about always defaulting to \n, maybe what we should do is ignore the difference between \n and \r\n when diffing, which also solves this issue.

[gopherbot]

Change https://go.dev/cl/627415 mentions this issue: cmd/goimports: ignore line breaks when comparing