You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
timothy-king opened this issue
Feb 28, 2024
· 4 comments
Assignees
Labels
AnalysisIssues related to static analysis (vet, x/tools/go/analysis)NeedsFixThe path to resolution is known, but the work has not been done.ToolsThis label describes issues relating to any tools in the x/tools repository.
x/tools/internal/versions currently interprets invalid/unknown language versions ("") as some unknown earliest version. go/types interprets an unknown language version as "an empty string disables Go language version checks" and treats this as if all language features are allowed. This is closer to treating this as if it is some unknown future version. x/tools should be consistent with go/types.
Users of internal/versions x/tools/go/analysis/passes/loopclosure and x/tools/go/ssa need to update their interpretation.
The text was updated successfully, but these errors were encountered:
timothy-king
added
NeedsFix
The path to resolution is known, but the work has not been done.
Analysis
Issues related to static analysis (vet, x/tools/go/analysis)
labels
Feb 28, 2024
Ok, that involves more steps, please see https://go.dev/wiki/MinorReleases.
Since this is the main tracking issue, let's move it to the Go1.23 milestone.
dmitshur
changed the title
x/tools/internal/versions: fix interpretation of empty language version
cmd/vet, x/tools/internal/versions: fix interpretation of empty language version
Feb 28, 2024
AnalysisIssues related to static analysis (vet, x/tools/go/analysis)NeedsFixThe path to resolution is known, but the work has not been done.ToolsThis label describes issues relating to any tools in the x/tools repository.
x/tools/internal/versions
currently interprets invalid/unknown language versions (""
) as some unknown earliest version.go/types
interprets an unknown language version as "an empty string disables Go language version checks" and treats this as if all language features are allowed. This is closer to treating this as if it is some unknown future version.x/tools
should be consistent withgo/types
.Users of internal/versions
x/tools/go/analysis/passes/loopclosure
andx/tools/go/ssa
need to update their interpretation.Related #65612.
The text was updated successfully, but these errors were encountered: