x/tools/gopls: bug in analysis importer reported by telemetry

[adonovan]

#!stacks
"bug.Errorf" &&
  ("cache.(*analysisNode)._import.func1:+41" || "cache.(*analysisNode)._import.func1:41")

This stack sbGdaw, hz09pg, zhKNnQ was reported by telemetry:

cache.(*analysisNode)._import.func1:41 is

		pkg, err := gcimporter.IImportShallow(an.fset, getPackages, an.summary.Export, string(an.m.PkgPath), bug.Reportf)
		if err != nil {
			an.typesErr = bug.Errorf("%s: invalid export data: %v", an.m, err)
			an.types = nil
		} else if pkg != an.types {
			log.Fatalf("%s: inconsistent packages", an.m)
		}

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:13
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?391
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:32
go/types.(*Checker).Files:?341
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck:117

golang.org/x/tools/gopls@v0.14.1 go1.21.3 linux/amd64 (1)

Reported using golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

Dups: NpfwWw OeW1wA

Duplicates:

This stack WRBqTw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:10
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?383
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:18
go/types.(*Checker).Files:?307
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck:117

golang.org/x/tools/gopls@v0.14.2 go1.19.13 darwin/arm64 (1)

This stack C7ZvyQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:13
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?399
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:29
go/types.(*Checker).Files:?372
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck:117

golang.org/x/tools/gopls@v0.14.2 go1.22rc2 darwin/arm64 other,vscode (1)

This stack 6jGwIA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:35
golang.org/x/tools/gopls/internal/util/bug.Errorf:2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:13
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?399
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:29
go/types.(*Checker).Files:?372
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:118

golang.org/x/tools/gopls@v0.15.0-pre.2 go1.22rc2 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

Dups: OeW1wA NpfwWw sNopDQ YUgxTQ g_3FdA qOlVPg sNopAA NpfwVg rcxYqw qOlVMw rcxYpg MCkoAw snYxVw 4YkxZg VaMCRQ oKR_eA

[findleyr]

We can live with this in v0.15.0. Let's move to v0.16.0

[adonovan]

This stack NpfwWw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import.func1:+41
sync.(*Once).doSlow:+5
sync.(*Once).Do:=65
golang.org/x/tools/gopls/internal/cache.(*analysisNode)._import:+1
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck.func2:+34
golang.org/x/tools/gopls/internal/cache.importerFunc.Import:+0
go/types.(*Checker).importPackage:+28
go/types.(*Checker).collectObjects.func1:+13
go/types.(*Checker).walkDecl:+9
go/types.(*Checker).walkDecls:=399
go/types.(*Checker).collectObjects:+42
go/types.(*Checker).checkFiles:+29
go/types.(*Checker).Files:=372
golang.org/x/tools/gopls/internal/cache.(*analysisNode).typeCheck:+118

golang.org/x/tools/gopls@v0.15.0-pre.3 go1.22.0 darwin/arm64 vscode (2)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

[adonovan]

This stack OeW1wA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/bug.report:35
golang.org/x/tools/gopls/internal/bug.Errorf:2
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import.func1:41
sync.(*Once).doSlow:5
sync.(*Once).Do:?65
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode)._import:1
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck.func2:34
golang.org/x/tools/gopls/internal/lsp/cache.importerFunc.Import:0
go/types.(*Checker).importPackage:28
go/types.(*Checker).collectObjects.func1:13
go/types.(*Checker).walkDecl:9
go/types.(*Checker).walkDecls:?399
go/types.(*Checker).collectObjects:42
go/types.(*Checker).checkFiles:36
go/types.(*Checker).Files:?355
golang.org/x/tools/gopls/internal/lsp/cache.(*analysisNode).typeCheck:117

golang.org/x/tools/gopls@v0.14.2 devel darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.