x/telemetry/upload: UploadConfig is sticky

[hyangah]

We originally thought upload would run from a separate process,
and made it to download the UploadConfig only once and keep using it.
(code)

But we ended up calling upload from a goroutine periodically in gopls integration.
This caused a long running gopls instance to keep using the same (or maybe stale) version of config throughout its lifetime.

cc @pjweinb @findleyr

[pjweinb]

it might be better if gopls only called upload.Run() once, right when it starts. As long as users restart gopls every couple of weeks that would be enough. And the go command is run a lot, so when it starts running telemetry, there's no reason for any executable to run Run() more than once.

…

On Thu, Aug 31, 2023 at 4:06 PM Hyang-Ah Hana Kim ***@***.***> wrote: We originally thought upload would run from a separate process, and made it to download the UploadConfig only once and keep using it. (code <https://github.com/golang/telemetry/blob/7b77db3ea9ad60adcaae36af38faf9ee6bc862d7/internal/upload/reports.go#L98> ) But we ended up calling upload from a goroutine periodically in gopls integration. This caused a long running gopls instance to keep using the same (or maybe stale) version of config throughout its lifetime. cc @pjweinb <https://github.com/pjweinb> @findleyr <https://github.com/findleyr> — Reply to this email directly, view it on GitHub <#62405>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJIAI6WOPC4KGL7KNIUFDLXYDVFFANCNFSM6AAAAAA4GSSWIQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[gopherbot]

Change https://go.dev/cl/524819 mentions this issue: gopls/internal/telemetry: don't schedule the next upload