-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile/internal/ssa: TestDebugLinesSayHi failures #60285
Comments
Found new dashboard test flakes for:
2023-05-18 09:16 linux-ppc64le-buildlet go@774f6022 cmd/compile/internal/ssa.TestDebugLinesSayHi (log)
|
Found new dashboard test flakes for:
2023-05-23 19:50 linux-ppc64-sid-power10 go@be91040e cmd/compile/internal/ssa.TestDebugLinesSayHi (log)
|
Found new dashboard test flakes for:
2023-05-23 20:25 linux-ppc64-sid-buildlet go@74af79bc cmd/compile/internal/ssa.TestDebugLinesSayHi (log)
|
Found new dashboard test flakes for:
2023-05-24 21:55 linux-ppc64-sid-power10 go@c5ba9d22 cmd/compile/internal/ssa.TestDebugLinesSayHi (log)
|
Found new dashboard test flakes for:
2023-05-25 00:56 linux-ppc64-sid-power10 go@d5a05a05 cmd/compile/internal/ssa.TestDebugLinesSayHi (log)
|
Found new dashboard test flakes for:
2023-05-30 16:05 linux-ppc64-sid-buildlet go@bfa25c3f cmd/compile/internal/ssa.TestDebugLinesSayHi (log)
|
This should be fixed by https://go.dev/cl/499679. The logs are similar to the other failures fixed by this CL, which started after PGO was used to build the compiler. That uncovered the bug where R29 was not preserved by gcWriteBarrier. (PGO -> more inlining -> larger functions -> more registers live at once -> R29 more likely to be allocated.) |
CL 499679 has landed — should this issue be closed now? |
I think this can be closed -- I just tried building the toolchain before this CL and can make this test fail quite easily, but cannot make the latest toolchain fail. I tried it on power8 BE & LE. |
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: