x/tools/gopls/internal/regtest/modfile: TestMissingDependencyFixesWithGoWork failures

[gopherbot]

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && test == "TestMissingDependencyFixesWithGoWork"

Bug automatically created to track these flakes.

— watchflakes

[gopherbot]

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && test == "TestMissingDependencyFixesWithGoWork"

2022-07-14 01:47 windows-arm64-10 tools@db8f89b3 go@a906d3dd golang.org/x/tools/gopls/internal/regtest/modfile.TestMissingDependencyFixesWithGoWork (log)

--- FAIL: TestMissingDependencyFixesWithGoWork (29.03s)
    --- FAIL: TestMissingDependencyFixesWithGoWork/default (19.90s)
        --- FAIL: TestMissingDependencyFixesWithGoWork/default/singleton (14.93s)
            runner.go:348: closing editor: Shutdown: context deadline exceeded
2022/07/14 20:22:53 cleaning workspace dir: remove C:\Users\gopher\AppData\Local\Temp\gopls-workspace-mod73934458: The process cannot access the file because it is being used by another process.
2022/07/14 20:23:08 cleaning workspace dir: remove C:\Users\gopher\AppData\Local\Temp\gopls-workspace-mod3502538941: The process cannot access the file because it is being used by another process.

2022-07-15 14:27 windows-arm64-10 tools@1a4e02fe go@4651ebf9 golang.org/x/tools/gopls/internal/regtest/modfile.TestMissingDependencyFixesWithGoWork (log)

goroutine profile: total 15
2 @ 0x7ff7c45a3b74 0x7ff7c4607a5c 0x7ff7c4607890 0x7ff7c4624660 0x7ff7c461e530 0x7ff7c461e521 0x7ff7c46506c0 0x7ff7c465b5e4 0x7ff7c465b5d9 0x7ff7c46ab580 0x7ff7c4647998 0x7ff7c47026b4 0x7ff7c4702691 0x7ff7c470351c 0x7ff7c460b404
#	0x7ff7c4607a5b	syscall.SyscallN+0xeb				C:/workdir/go/src/runtime/syscall_windows.go:557
#	0x7ff7c460788f	syscall.Syscall6+0x3f				C:/workdir/go/src/runtime/syscall_windows.go:501
#	0x7ff7c462465f	syscall.readFile+0x7f				C:/workdir/go/src/syscall/zsyscall_windows.go:1024
#	0x7ff7c461e52f	syscall.ReadFile+0x2f				C:/workdir/go/src/syscall/syscall_windows.go:400
#	0x7ff7c461e520	syscall.Read+0x20				C:/workdir/go/src/syscall/syscall_windows.go:379
#	0x7ff7c46506bf	internal/poll.(*FD).Read+0x1af			C:/workdir/go/src/internal/poll/fd_windows.go:427
#	0x7ff7c465b5e3	os.(*File).read+0x63				C:/workdir/go/src/os/file_posix.go:31
#	0x7ff7c465b5d8	os.(*File).Read+0x58				C:/workdir/go/src/os/file.go:118
...
#	0x7ff7c4606157	sync.runtime_Semacquire+0x27							C:/workdir/go/src/runtime/sema.go:62
#	0x7ff7c461a15f	sync.(*WaitGroup).Wait+0x7f							C:/workdir/go/src/sync/waitgroup.go:139
#	0x7ff7c4d48b2b	golang.org/x/tools/internal/lsp.(*Server).diagnoseSnapshots+0x1cb		C:/workdir/gopath/src/golang.org/x/tools/internal/lsp/diagnostics.go:108
#	0x7ff7c4d60a77	golang.org/x/tools/internal/lsp.(*Server).processModifications.func1+0x37	C:/workdir/gopath/src/golang.org/x/tools/internal/lsp/text_synchronization.go:300

--- FAIL: TestMissingDependencyFixesWithGoWork (30.08s)
    --- FAIL: TestMissingDependencyFixesWithGoWork/default (19.76s)
        --- FAIL: TestMissingDependencyFixesWithGoWork/default/singleton (12.88s)
            runner.go:348: closing editor: Shutdown: context deadline exceeded
2022/07/15 14:52:40 cleaning workspace dir: remove C:\Users\gopher\AppData\Local\Temp\gopls-workspace-mod2676969338: The process cannot access the file because it is being used by another process.

— watchflakes

[rsc]

Stopped.

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/modfile" && test == "TestMissingDependencyFixesWithGoWork"

2023-04-06 17:53 windows-amd64-race tools@c5f768a4 go@4526fa79 x/tools/gopls/internal/regtest/modfile.TestMissingDependencyFixesWithGoWork (log)

runtime: bad pointer in frame os.(*File).readdir at 0xc00032dba8: 0x508
fatal error: invalid pointer found on stack

runtime stack:
runtime.throw({0x1411a88d9?, 0x141b01fa0?})
	C:/workdir/go/src/runtime/panic.go:1076 +0x65 fp=0x2803f8e0 sp=0x2803f8b0 pc=0x14003abe5
runtime.adjustpointers(0x2803fb58?, 0x2803f9a0, 0x1400607bf?, {0x2803fb58?, 0x0?})
	C:/workdir/go/src/runtime/stack.go:632 +0x1ad fp=0x2803f940 sp=0x2803f8e0 pc=0x14005294d
runtime.adjustframe(0x2803fb58, 0x2803fa38)
	C:/workdir/go/src/runtime/stack.go:673 +0xbb fp=0x2803f9d0 sp=0x2803f940 pc=0x140052a5b
...
	C:/workdir/go/src/runtime/chan.go:583 +0x385 fp=0xc000c97be8 sp=0xc000c97b70 pc=0x140007245
runtime.chanrecv1(0x141b686e0?, 0x140fff240?)
	C:/workdir/go/src/runtime/chan.go:442 +0x12 fp=0xc000c97c10 sp=0xc000c97be8 pc=0x140006e92
testing.(*T).Run(0xc000718000, {0x141169c84, 0x6}, 0xc000bdee10)
	C:/workdir/go/src/testing/testing.go:1649 +0x865 fp=0xc000c97d30 sp=0xc000c97c10 pc=0x1401c2785
golang.org/x/tools/gopls/internal/lsp/regtest.RunMultiple.Run({0xc000c97e48, 0x2, 0x1?}, 0x5ad?, {0x1411da490, 0xc0}, 0x1412ed720)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:76 +0x8e fp=0xc000c97da8 sp=0xc000c97d30 pc=0x140f0c4ce
golang.org/x/tools/gopls/internal/regtest/modfile.TestMissingDependencyFixesWithGoWork(0x0?)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/modfile/modfile_test.go:276 +0x32d fp=0xc000c97e98 sp=0xc000c97da8 pc=0x140f1b80d
testing.tRunner(0xc000718000, 0x1412ed728)

— watchflakes

[findleyr]

This does not look like an actual recurrence, but rather a runtime bug?

runtime: bad pointer in frame os.(*File).readdir at 0xc00032dba8: 0x508
fatal error: invalid pointer found on stack

CC @golang/runtime to confirm. I can open a new issue for the runtime bug, if none exists.

[prattmic]

FWIW, we also got a very similar failure at #55308 (comment)

[findleyr]

Thanks for the quick response. #55308 looks like a more approprate bug for discussion, so I'll close this one and remove it from the Test Flakes project.