x/tools/internal/lsp: TestLSP/GOPATH failure with "race detected during execution of test"

[dmitshur]

2022/08/02 19:20:54 New session
	create_session=1
2022/08/02 19:20:56 go/packages.Load #1
[...]
==================
WARNING: DATA RACE
Read at 0x00c0086205a0 by goroutine 34461:
  golang.org/x/tools/internal/lsp/cache.(*snapshot).load()
      /tmp/workdir/gopath/src/golang.org/x/tools/internal/lsp/cache/load.go:144 +0x11a6
  golang.org/x/tools/internal/lsp/cache.(*snapshot).loadWorkspace()
      /tmp/workdir/gopath/src/golang.org/x/tools/internal/lsp/cache/view.go:710 +0x38b
  golang.org/x/tools/internal/lsp/cache.(*snapshot).initialize()
      /tmp/workdir/gopath/src/golang.org/x/tools/internal/lsp/cache/view.go:645 +0x229
  golang.org/x/tools/internal/lsp/cache.(*Session).createView.func4()
      /tmp/workdir/gopath/src/golang.org/x/tools/internal/lsp/cache/session.go:268 +0x8d

Previous write at 0x00c0086205a0 by goroutine 34426:
  golang.org/x/tools/internal/lsp/cache.(*View).SetOptions()
[...]
2022/08/02 19:22:47 go/packages.Load #30
	snapshot=1
	package="command-line-arguments"
	files=[/tmp/workdir/go/src/builtin/builtin.go]
2022/08/02 19:22:47 go/packages.Load #30: updating metadata for 1 packages
2022/08/02 19:22:49 no signature help: no signature help within a string literal
	position={49 5}
2022/08/02 19:22:49 no signature help: no signature help within a function declaration
	position={76 2}
--- FAIL: TestLSP (119.09s)
    --- FAIL: TestLSP/GOPATH (48.73s)
        testing.go:1319: race detected during execution of test
    testing.go:1319: race detected during execution of test
FAIL
FAIL	golang.org/x/tools/internal/lsp	119.292s

2022-08-02T18:52:36-0d04f65-4345620/freebsd-amd64-race

[findleyr]

Dupe of #54214.

[dmitshur]

Thanks and sorry I missed it. I changed the prefix in the title of #54214 to follow the usual convention so it'll be easier to find.

[findleyr]

Thanks, don't know what I was thinking with that issue title! (how many issues have I filed...?!)