New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/tour: "Run" button becomes "Kill" on compilation error #50921

Closed

enocom opened this issue Jan 31, 2022 · 1 comment

Labels

NeedsFix

Milestone

enocom commented Jan 31, 2022

To reproduce, visit any page with a playground on https://go.dev/tour:

Write something that will not compile, e.g.,

package main

// missing close quote
import "fmt 

func main() {
	fmt.Println("Hello, World")
}

Click "Run".
Compilation error is reported, but the "Run" button is now stuck on "Kill"

Expected behavior:

After clicking "Run", the button should return to "Run" with a compilation error.

gopherbot added this to the Unreleased milestone

enocom mentioned this issue

tour: "Run" button becomes "Kill" on compilation error golang/tour#1309

Closed

toothrot added the NeedsFix label

Contributor

gopherbot commented Mar 22, 2023

Change https://go.dev/cl/478415 mentions this issue: tour: call 'done' callback after Run, on message Kind 'system'

gopherbot closed this as completed in


      golang/website@a84f6ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment