cmd/go: suggest 'go get' for packages in the main module instead of missing external package paths #46806
Labels
BadErrorMessage
Issues related compiler error messages that should be better.
GoCommand
cmd/go
modules
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
In #45979 (comment), I noted that
go get
in ago 1.17
module adds its arguments as// indirect
.As an intentional consequence of #45965, we place the
// indirect
dependencies in a separate section of thego.mod
file from the direct dependencies. That potentially makes these new actually-direct dependencies more difficult to spot.If we saw the import of the missing package from within the main module to begin with, we would add it without the erroneous
// indirect
marking, and avoid the churn of moving it between sections. So I think we should suggest a command that does that, instead of suggestinggo get
on the specific missing package(s).That would also help to eliminate some of the redundancy in the
go get
hints (#43653).CC @jayconrod @matloob @stevetraut
The text was updated successfully, but these errors were encountered: