cmd/go: use different output dirs with -tags

[rsc]

Using go install -tags foo and go install will both install package objects to the same
place. Binaries too. That's probably a mistake. Right now there is a special case for
-race. Maybe it should not be so special.

[rsc]

Comment 1:

Labels changed: added size-m.

[bradfitz]

Comment 2:

This has been biting me.
ba12:camlistore.org bradfitz$ go test ./pkg/index/sqlite/
warning: building out-of-date packages:
    camlistore.org/pkg/test
    camlistore.org/pkg/index/indextest
installing these packages with 'go test -i ./pkg/index/sqlite/' will speed future tests.
^[[Apanic: camlistored was not built with SQLite support. Rebuild with go get/install
--tags=with_sqlite  [recovered]
    panic: camlistored was not built with SQLite support. Rebuild with go get/install --tags=with_sqlite 
goroutine 3 [running]:
testing.func·003(0x1105efa8, 0x1105d100)
    /Users/bradfitz/go/src/pkg/testing/testing.go:296 +0xc3
 
Adding --tags for the test does nothing:
ba12:camlistore.org bradfitz$ go test --tags=with_sqlite ./pkg/index/sqlite/
warning: building out-of-date packages:
    camlistore.org/pkg/test
    camlistore.org/pkg/index/indextest
installing these packages with 'go test -i ./pkg/index/sqlite/' will speed future tests.
panic: camlistored was not built with SQLite support. Rebuild with go get/install
--tags=with_sqlite  [recovered]
    panic: camlistored was not built with SQLite support. Rebuild with go get/install --tags=with_sqlite 
goroutine 3 [running]:
testing.func·003(0x1105efa8, 0x1105d100)
    /Users/bradfitz/go/src/pkg/testing/testing.go:296 +0xc3
But if I do -i:
ba12:camlistore.org bradfitz$ go test -i --tags=with_sqlite ./pkg/index/sqlite/
Then it works:
 ba12:camlistore.org bradfitz$ go test --tags=with_sqlite ./pkg/index/sqlite/
ok      camlistore.org/pkg/index/sqlite 0.256s
Related to issue #3832 and issue #3895?

[bradfitz]

Comment 3:

Russ, any new thoughts on this? I'd like to include the tags in the pkg/os-arch-tags dir.

[rsc]

Comment 4:

Labels changed: added priority-later, removed priority-soon.

[rsc]

Comment 5:

Labels changed: added go1.1maybe, removed go1.1.

[dsymonds]

Comment 6:

FYI, this matters to App Engine (supporting testing, etc.).

[rsc]

Comment 7:

Okay, back to Go 1.1. But I'm still not 100% sure how this should work. Sometimes a
different -tags does not need to create a whole new output tree nor to rebuild
everything from scratch. Perhaps instead of reusing -tags there should be a separate
-buildlabel that specifies a suffix to use when naming the install directory.

Labels changed: added go1.1, removed go1.1maybe.

[rsc]

Comment 8:

This issue was closed by revision e778f93.

Status changed to Fixed.