Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: tests fail on race TryBots after CL 201783 #35121

Closed
stamblerre opened this issue Oct 23, 2019 · 1 comment
Closed

x/tools/gopls: tests fail on race TryBots after CL 201783 #35121

stamblerre opened this issue Oct 23, 2019 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

The gopls cache relies on the internal/memoize package, which fails valid with -d=checkptr. CL 201783 added -d=checkptr to the -race flag, causing the gopls tests to fail on the race builders.

Related to #34964
@gopherbot gopherbot added this to the Unreleased milestone Oct 23, 2019
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Oct 23, 2019
@zikaeroh zikaeroh mentioned this issue Oct 23, 2019
Closed
@stamblerre
Copy link
Contributor Author

Fixed via CL 203078.

@golang golang locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot