Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: sigtramp seems wrong in sys_linux_arm.s #32738

Closed
ghost opened this issue Jun 22, 2019 · 2 comments
Closed

runtime: sigtramp seems wrong in sys_linux_arm.s #32738

ghost opened this issue Jun 22, 2019 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@ghost
Copy link

ghost commented Jun 22, 2019

As in issue #31827, the callee saved register should be saved/restored in sigtramp.

The callee saved registers are handled in sigtramp of sys_darwin_arm.s, but not in sys_linux _arm.s / sys_openbsd_arm.s / sys_netbsd_arm.s.

Though tsan_test.go passed on arm, there are still potential risks.
@agnivade
Copy link
Contributor

@cherrymui @ianlancetaylor

@agnivade agnivade added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 23, 2019
@ianlancetaylor ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 23, 2019
@ianlancetaylor ianlancetaylor added this to the Go1.14 milestone Jun 23, 2019
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 23, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/183777 mentions this issue: runtime: save/restore callee-save registers in arm's sigtramp

@agnivade agnivade mentioned this issue Jul 3, 2019
Closed
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@benshi001 benshi001 modified the milestones: Backlog, Go1.14 Oct 11, 2019
@thefloweringash thefloweringash mentioned this issue Jan 4, 2020
Merged
10 tasks
@golang golang locked and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@rsc @agnivade @ianlancetaylor @gopherbot @benshi001