Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNU Make 3.8.0's lastword seems broken #30

Closed
gopherbot opened this issue Nov 11, 2009 · 4 comments
Closed

GNU Make 3.8.0's lastword seems broken #30

gopherbot opened this issue Nov 11, 2009 · 4 comments

Comments

@gopherbot
Copy link
Contributor

by julians37:

What steps will reproduce the problem?
What is the expected output? What do you see instead?

In src/Make.pkg, $(elem) is empty even though $(TARG) is not.

What is your $GOOS?  $GOARCH?

linux_386

Which revision are you sync'ed to?  (hg log -l 1)

3975:b51fd2d6c160

Please provide any additional information below.

GNU Make 3.8.0's lastword function appears to be broken. I've replaced it 
with the alternative suggested in Make's manual and that worked (even 
though the manual states the two are identical). Patch attached.

Attachments:

  1. golang_lastword.patch (433 bytes)
@gopherbot
Copy link
Contributor Author

Comment 1 by julians37:

Sorry, this should read GNU Make 3.80, not 3.8.0

@rsc
Copy link
Contributor

rsc commented Nov 11, 2009

Comment 2:

Owner changed to [email protected].

Status changed to Started.

@agl
Copy link
Contributor

agl commented Nov 11, 2009

Comment 3:

I think we can safely say that we need make 3.81.
I've suggested http://golang.org/cl/154062, but it might be too much bother. 
On the other hand, it might save some people the debugging time in future.
Thanks!

@rsc
Copy link
Contributor

rsc commented Nov 11, 2009

Comment 4:

This issue was closed by revision 3849325.

Status changed to Fixed.

Merged into issue #-.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants