Tests fail in China

[gopherbot]

by jan.newmarch:

www.google.com is blocked in China. So the test net.TestDialGoogle fails, aborting all
the rest of the tests. Preferred if failure is reported but the tests continue

--- FAIL: net.TestDialGoogle
    -- 74.125.19.99:80 --
    -- www.google.com:80 --
    Dial("tcp4", "", "www.google.com:80") = _, dial tcp4 66.249.89.104:80: connection timed out

8g version 6288 release release.2010-09-15

[adg]

Comment 1:

I'm not sure what the general fix is, here. We could define an environment variable that
you can set (TESTHOST or similar) to override the google.com default.
Otherwise, just add 'net' and 'http' to the NOTEST list in src/pkg/Makefile.

Owner changed to [email protected].

Status changed to Thinking.

[peterGo]

Comment 2:

pkg/Makefile: allow DISABLE_NET_TESTS=1 to disable network tests
http://golang.org/cl/1689046

[rsc]

Comment 3:

DISABLE_NET_TESTS is the right fix for now.
When we redo http we will make the tests
not depend on external servers.

Status changed to Duplicate.

Merged into issue #20.