From 376076f3c6bed06f5256a316af8f1eed53a1135e Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Wed, 4 Jan 2023 18:03:46 -0800 Subject: [PATCH] runtime: skip TestCgoPprofCallback in short mode, don't run in parallel Fixes #54778 Change-Id: If9aef0c06b993ef2aedbeea9452297ee9f11fa06 Reviewed-on: https://go-review.googlesource.com/c/go/+/460461 Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor TryBot-Result: Gopher Robot Auto-Submit: Ian Lance Taylor Reviewed-by: Michael Pratt Run-TryBot: Ian Lance Taylor --- src/runtime/crash_cgo_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go index ba0e9f4ceda7c4..51d7bb50915d8e 100644 --- a/src/runtime/crash_cgo_test.go +++ b/src/runtime/crash_cgo_test.go @@ -218,7 +218,9 @@ func TestCgoCCodeSIGPROF(t *testing.T) { } func TestCgoPprofCallback(t *testing.T) { - t.Parallel() + if testing.Short() { + t.Skip("skipping in short mode") // takes a full second + } switch runtime.GOOS { case "windows", "plan9": t.Skipf("skipping cgo pprof callback test on %s", runtime.GOOS)