Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Add logic to disallow import cycles #439

Closed
fabulous-gopher opened this issue Apr 21, 2017 · 0 comments
Closed

Add logic to disallow import cycles #439

fabulous-gopher opened this issue Apr 21, 2017 · 0 comments

Comments

@fabulous-gopher
Copy link

From @sdboyer on July 19, 2016 19:21

There's a spot just waiting to do it in the checkProject() and checkPackage() methods.

For now, it's probably fine to use an offline algorithm (e.g., Tarjan SCC) to find cycles. That gives us linear time in the number of packages and dependencies. Brief searches suggest that there's probably a sublinear incremental cycle discovery algorithm out there that we can swap in later.

Copied from original issue: sdboyer/gps#66

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants