Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: wrap errors from client handshake #266

Closed
wants to merge 1 commit into from
Closed

ssh: wrap errors from client handshake #266

wants to merge 1 commit into from

Conversation

paxan
Copy link
Contributor

@paxan paxan commented Jul 12, 2023 •
edited by dmitshur
Loading

When an error is returned by a user defined host key callback,
it is now possible to handle it using standard Go mechanisms
such as errors.Is or errors.As.

Fixes golang/go#61309

@paxan
ssh: wrap errors from client handshake
d2a34d5 
When an error is returned by a user defined host key callback,
it is now possible to handle it using standard Go mechanisms
such as errors.Is or errors.As.

Fixes golang/go#61309
@gopherbot
Copy link
Contributor

This PR (HEAD: d2a34d5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/508876 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nicola Murino:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Muhammad Shulhan:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nicola Murino:

Patch Set 1: Commit-Queue+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nicola Murino:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

CV cannot start a Run for [email protected] because the user is neither the CL owner nor a committer.

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nicola Murino:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Muhammad Shulhan:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nicola Murino:

Patch Set 1: Commit-Queue+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nicola Murino:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

CV cannot start a Run for [email protected] because the user is neither the CL owner nor a committer.

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@kke kke mentioned this pull request Nov 7, 2023
Closed
@gopherbot
Copy link
Contributor

Message from Nicola Murino:

Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-25T11:48:31Z","revision":"a75e6c1aadb274221da5b031c5a74218a92bb19b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nicola Murino:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Failed Tryjobs:

FAILURE

error: failed to run "test golang.org/x/crypto module": exit status 1

FAILURE

error: failed to run "test golang.org/x/crypto module": exit status 1

FAILURE

error: failed to run "test golang.org/x/crypto module": exit status 1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nicola Murino:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-25T13:23:47Z","revision":"a75e6c1aadb274221da5b031c5a74218a92bb19b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nicola Murino:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_crypto-gotip-linux-amd64 has failed with summary (view all results):

FAILURE

error: failed to run "test golang.org/x/crypto module": exit status 1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: d2a34d5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/508876.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 2: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/508876.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 27, 2023
@paxan @gopherbot
ssh: wrap errors from client handshake
7e6fbd8 
When an error is returned by a user defined host key callback,
it is now possible to handle it using standard Go mechanisms
such as errors.Is or errors.As.

Fixes golang/go#61309

Change-Id: I4269c5f8eacd8e7e8d85070ad249f0e27777b15f
GitHub-Last-Rev: d2a34d5
GitHub-Pull-Request: #266
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/508876
Run-TryBot: Nicola Murino <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Muhammad Shulhan <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Nicola Murino <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/508876 has been merged.

@gopherbot gopherbot closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/crypto/ssh: error from ssh.HostKeyCallback is not wrapped during handshake
2 participants
@paxan @gopherbot