Skip to content

Commit 20ebdbd

Browse files
Bryan C. Millsgopherbot
Bryan C. Mills
authored andcommitted
dashboard: unmark known-issues with low failure rates
I had initially added known issues fairly aggressively in order to use them to reduce noise in 'greplogs -triage'. Now that we are using 'watchflakes' for triage, that noise reduction is no longer important (the failures are already clustered to their respective known issues), and having greyed-out cells on the dashboard makes new regressions too easy to miss. Concretely: - golang/go#42212 is mostly specific to x/net at this point (as golang/go#57841) - There have been no failures matching golang/go#51001 since October. - golang/go#52724 has been so rare lately that we hadn't yet added a 'watchflakes' pattern for it. - There have been no failures matching golang/go#51443 since May. - There have been no failures matching golang/go#53116 or golang/go#53093 since I enabled 'watchflakes' for the builder in December. - The linux-amd64-perf builder seems to be passing consistently for x/benchmarks and x/tools, so there is no need to refer to golang/go#53538 to explain failures on it. Change-Id: Ia16db2a23e5fa037a299f1f56fb26f1cf84521e1 Reviewed-on: https://go-review.googlesource.com/c/build/+/465156 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Bryan Mills <[email protected]> Auto-Submit: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent 4a5d2d0 commit 20ebdbd

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

Diff for: dashboard/builders.go

+4-9
Original file line numberDiff line numberDiff line change
@@ -2612,7 +2612,6 @@ func init() {
26122612
"GOHOSTOS=linux",
26132613
"CGO_ENABLED=1",
26142614
},
2615-
KnownIssues: []int{42212, 51001, 52724},
26162615
})
26172616
addBuilder(BuildConfig{
26182617
Name: "android-amd64-emu",
@@ -2644,18 +2643,16 @@ func init() {
26442643
"GOHOSTOS=linux",
26452644
"CGO_ENABLED=1",
26462645
},
2647-
KnownIssues: []int{42212, 51001, 52724},
26482646
})
26492647
addBuilder(BuildConfig{
26502648
Name: "illumos-amd64",
26512649
HostType: "host-illumos-amd64-jclulow",
26522650
})
26532651
addBuilder(BuildConfig{
2654-
Name: "solaris-amd64-oraclerel",
2655-
HostType: "host-solaris-oracle-amd64-oraclerel",
2656-
Notes: "Oracle Solaris release version",
2657-
FlakyNet: true,
2658-
KnownIssues: []int{51443},
2652+
Name: "solaris-amd64-oraclerel",
2653+
HostType: "host-solaris-oracle-amd64-oraclerel",
2654+
Notes: "Oracle Solaris release version",
2655+
FlakyNet: true,
26592656
})
26602657
addBuilder(BuildConfig{
26612658
Name: "linux-ppc64-sid-buildlet",
@@ -2768,7 +2765,6 @@ func init() {
27682765
"GOARCH=loong64",
27692766
"GOHOSTARCH=loong64",
27702767
},
2771-
KnownIssues: []int{53116, 53093},
27722768
})
27732769
addBuilder(BuildConfig{
27742770
FlakyNet: true,
@@ -3023,7 +3019,6 @@ func init() {
30233019
},
30243020
RunBench: true,
30253021
SkipSnapshot: true,
3026-
KnownIssues: []int{53538},
30273022
})
30283023
}
30293024

0 commit comments

Comments
 (0)