Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese characters cannot refresh completly #985

Closed
scorpionxyz opened this issue Oct 29, 2022 · 3 comments
Closed

Chinese characters cannot refresh completly #985

scorpionxyz opened this issue Oct 29, 2022 · 3 comments

Comments

@scorpionxyz
Copy link

When change the directory, the chinese characters will not refreshed completly if there is no english characters cover it.

@ilyagr
Copy link
Collaborator

ilyagr commented Oct 29, 2022

This sounds like a difficult bug to diagnose and fix. It could be a bug in your terminal, in lf, or in a library that lf is using.

  • Try to compile the version of lf from the master branch. We updated some libraries we depend on, it may help.
  • Try different terminals. If you use tmux, try to reproduce the bug without tmux.
  • If nothing helps, we would need more details, and even then we may or may not be able to help. You could do more research on what the problem could be and share that. You could also share a detailed enough bug report that we can try to reproduce it. Find the simplest directory structure where you can reproduce the bug, zip it up, attach it to a bug, and explain exactly what we need to do to see it. (There are many ways to "change the directory").

@gokcehan
Copy link
Owner

Possible duplicate #644

@joelim-work
Copy link
Collaborator

Probably because the widths are not calculated properly for CJK characters by the go-runewidth library. This has recently been updated to support the latest version of Unicode (15.1.0 at time of writing), see 534710d.

Hopefully this should fix the issue - if not feel free to reopen with a minimal and properly reproducible example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants