Rename To Preserve Extension #279

smhmd · 2019-12-25T05:40:39Z

rename: README.md│ should instead be rename: README│.md as keeping the extension is a more common use case.

The recommended way in the wiki removes the extension (and leaves the dot) and forces you to have multiple keybindings for files, files without extensions and directories.

The text was updated successfully, but these errors were encountered:

lucas-mior · 2019-12-27T17:12:20Z

very ugly solution (map it to A or whatever you like)

cmd renameappend ${{
filename="${f%.*}"
nome="$(basename "$filename")"
lf -remote "send $id :rename; cmd-home"
chars="$(echo $nome | wc -m)"
n=1
while [[ $n -lt $chars ]]
do
lf -remote "send $id cmd-right"
n=$((n+1))
done
}}

roket1428 · 2019-12-30T22:20:57Z

My solution:

cmd rename-before-ext &{{
	if [ "$(echo "$fx" | wc -l)" -gt 1 ]; then
		lf -remote "send $id echo You can't change more than one file name"
		lf -remote "send $id unselect"
	else
		if [ -d "$f" ]; then
			lf -remote "send $id rename"
		else
			ext_len="$(echo ${f##*.} | wc -m)"
			for i in $(seq "$ext_len"); do
				pos="${pos}<left>"
			done
			lf -remote "send $id rename"
			lf -remote "send $id push "$pos""
		fi
	fi
}}

Limero · 2020-01-03T22:30:20Z

I agree that keeping the extension is the most common when renaming. Should we make this the default behavior? Should there be an option to toggle it? Would be nice to not have to use custom commands.

smhmd · 2020-01-03T22:38:05Z

@Limero I think it should be the default. If you wanna change the entire name you would ctrl+u.

roket1428 · 2020-01-03T23:04:52Z

I agree that keeping the extension is the most common when renaming. Should we make this the default behavior? Should there be an option to toggle it? Would be nice to not have to use custom commands.

I think there gotta be at least 4 default naming function: One for renaming it entirely (like just let me change its name to this new value), one for appending (at the very end of the file/directory), one for inserting (at the very beginning of the file/directory), one for appending before the extension of the file (default behavior for directories should be same as appending IMHO).

Here is my lfrc for those (yes, I use hard tabs and I don't care what you think):

# insert
cmd rename-insert &{{
	if [ "$(echo "$fx" | wc -l)" -gt 1 ]; then
		lf -remote "send $id echo You can't change more than one file name"
		lf -remote "send $id unselect"
	else
		len="$(basename "$f" | wc -m)" # length of selected file/directory
		for i in $(seq "$len"); do
			pos="${pos}<left>" # how many times do I have to press <left> in order to get first char
		done
		lf -remote "send $id rename"
		lf -remote "send $id push $pos"
	fi
}}

# append before ext
cmd rename-before-ext &{{
	if [ "$(echo "$fx" | wc -l)" -gt 1 ]; then
		lf -remote "send $id echo You can't change more than one file name"
		lf -remote "send $id unselect"
	else
		if [ -d "$f" ]; then
			lf -remote "send $id rename"
		else
			ext_len="$(echo ${f##*.} | wc -m)" # extention length
			for i in $(seq "$ext_len"); do
				pos="${pos}<left>"
			done
			lf -remote "send $id rename"
			lf -remote "send $id push "$pos""
		fi
	fi
}}

# change its name entirely
cmd rename-new &{{
	if [ "$(echo "$fx" | wc -l)" -gt 1 ]; then
		lf -remote "send $id echo You can't change more than one file name"
		lf -remote "send $id unselect"
	else
		lf -remote "send $id rename"
		lf -remote "send $id push <c-u>"
	fi
}}

map cc rename-new # new name
map I rename-insert # at the very begging
map A rename # at the very end
map aa rename-before-ext # right before the extention

gokcehan · 2020-01-10T12:21:06Z

Thank you all for the feedback. For the record, this is why I try not to include commands as builtin because everyone has some slightly different favorite and expects it to be the default. The current default seems to be the simpler one rather than the common one. You should be able to define other versions of rename commands using either push command:

map R push r<a-b><c-b>

Or by using command line commands:

map R :rename; cmd-word-back; cmd-left

Examples in the wiki page dates back to times we did not have a builtin rename command. Perhaps it is time to remove those examples in favor of these.

smhmd · 2020-01-10T16:31:01Z

I really think sane, great defaults are better than having two commands for renaming.

EDIT: you might as well throw bulk renaming when multiple files are selected in there. and have these defaults in /usr/local/etc/lf/lfrc for easy copy, edit.

In this case, someone is going to realize some command could be better written, and we're all going to benefit. It feels like lf consciously wants people to have custom commands for everything.

roket1428 · 2020-02-09T05:41:42Z

I agree that keeping the extension is the most common when renaming. Should we make this the default behavior? Should there be an option to toggle it? Would be nice to not have to use custom commands.

I think there gotta be at least 4 default naming function: One for renaming it entirely (like just let me change its name to this new value), one for appending (at the very end of the file/directory), one for inserting (at the very beginning of the file/directory), one for appending before the extension of the file (default behavior for directories should be same as appending IMHO).

Here is my lfrc for those (yes, I use hard tabs and I don't care what you think):
# insert
cmd rename-insert &{{
	if [ "$(echo "$fx" | wc -l)" -gt 1 ]; then
		lf -remote "send $id echo You can't change more than one file name"
		lf -remote "send $id unselect"
	else
		len="$(basename "$f" | wc -m)" # length of selected file/directory
		for i in $(seq "$len"); do
			pos="${pos}<left>" # how many times do I have to press <left> in order to get first char
		done
		lf -remote "send $id rename"
		lf -remote "send $id push $pos"
	fi
}}

# append before ext
cmd rename-before-ext &{{
	if [ "$(echo "$fx" | wc -l)" -gt 1 ]; then
		lf -remote "send $id echo You can't change more than one file name"
		lf -remote "send $id unselect"
	else
		if [ -d "$f" ]; then
			lf -remote "send $id rename"
		else
			ext_len="$(echo ${f##*.} | wc -m)" # extention length
			for i in $(seq "$ext_len"); do
				pos="${pos}<left>"
			done
			lf -remote "send $id rename"
			lf -remote "send $id push "$pos""
		fi
	fi
}}

# change its name entirely
cmd rename-new &{{
	if [ "$(echo "$fx" | wc -l)" -gt 1 ]; then
		lf -remote "send $id echo You can't change more than one file name"
		lf -remote "send $id unselect"
	else
		lf -remote "send $id rename"
		lf -remote "send $id push <c-u>"
	fi
}}

map cc rename-new # new name
map I rename-insert # at the very begging
map A rename # at the very end
map aa rename-before-ext # right before the extention

After tweaking a bit, I realized that I can shorten it to this:

map cc push A<c-u> # new rename
map I push A<c-a> # at the very beginning
map A rename # at the very end
map i push A<a-b><a-b><a-f> # before extention
map a push A<a-b> # after extention

doronbehar · 2020-03-13T21:12:49Z

Hey all :) I'm the one who wrote that section at the wiki and I've just stumbled upon this discussion. Just wanted to let you know I've edited that wiki section with a link to this issue and I've made the commands handle filenames with quotes and possibly other characters better, using a printf '%q'.

You might also be interested in #306 .

roket1428 · 2020-03-14T08:50:46Z

I agree that keeping the extension is the most common when renaming. Should we make this the default behavior? Should there be an option to toggle it? Would be nice to not have to use custom commands.

I think there gotta be at least 4 default naming function: One for renaming it entirely (like just let me change its name to this new value), one for appending (at the very end of the file/directory), one for inserting (at the very beginning of the file/directory), one for appending before the extension of the file (default behavior for directories should be same as appending IMHO).
Here is my lfrc for those (yes, I use hard tabs and I don't care what you think):
# insert
cmd rename-insert &{{
	if [ "$(echo "$fx" | wc -l)" -gt 1 ]; then
		lf -remote "send $id echo You can't change more than one file name"
		lf -remote "send $id unselect"
	else
		len="$(basename "$f" | wc -m)" # length of selected file/directory
		for i in $(seq "$len"); do
			pos="${pos}<left>" # how many times do I have to press <left> in order to get first char
		done
		lf -remote "send $id rename"
		lf -remote "send $id push $pos"
	fi
}}

# append before ext
cmd rename-before-ext &{{
	if [ "$(echo "$fx" | wc -l)" -gt 1 ]; then
		lf -remote "send $id echo You can't change more than one file name"
		lf -remote "send $id unselect"
	else
		if [ -d "$f" ]; then
			lf -remote "send $id rename"
		else
			ext_len="$(echo ${f##*.} | wc -m)" # extention length
			for i in $(seq "$ext_len"); do
				pos="${pos}<left>"
			done
			lf -remote "send $id rename"
			lf -remote "send $id push "$pos""
		fi
	fi
}}

# change its name entirely
cmd rename-new &{{
	if [ "$(echo "$fx" | wc -l)" -gt 1 ]; then
		lf -remote "send $id echo You can't change more than one file name"
		lf -remote "send $id unselect"
	else
		lf -remote "send $id rename"
		lf -remote "send $id push <c-u>"
	fi
}}

map cc rename-new # new name
map I rename-insert # at the very begging
map A rename # at the very end
map aa rename-before-ext # right before the extention
After tweaking a bit, I realized that I can shorten it to this:
map cc push A<c-u> # new rename
map I push A<c-a> # at the very beginning
map A rename # at the very end
map i push A<a-b><a-b><a-f> # before extention
map a push A<a-b> # after extention

Okay, this is last, I promise. :)

I realized that "before extension" keybinding has one bug. Right now, it goes to the very end of filename thanks to default rename function then goes back one word, and then goes one word back again. After that, it goes forward by one word.

This goes right before the . in a filename format like this <alphanumeric file name>.<ext> but if the file name contains something like " right before the ., it just goes right before the ". So, it needs a fix and that is map i push A<a-b><c-b>.

This first goes to the very end of filename, and goes one word back (right after the .), and then, goes back one character which is the .. So, you'll end up right before the ..

Thanks to @doronbehar to help me realize it. :)

Anyways, have a nice day. :)

doronbehar · 2020-03-14T12:59:21Z

Answering your comment #306 (comment) which to my view relates to the discussion here more then there.

And while you are writing functions/scripts to lf, prefer POSIX shell scripting as not everyone uses bash as default shell.

Totally agree with you, but replacing printf '%q' with a posix shell equivalent seems like too much effort for an edge case, see https://stackoverflow.com/a/29824428/4935114 . I've added a note to the wiki indicating this was tested with zsh.

gokcehan · 2020-03-18T18:51:29Z

I think the best argument in favor of this is that it is easier to define the other behaviors when the default is keeping the extension since there could be files with no extension or multiple extensions. If anyone wants to implement this, I'm now willing to accept a PR. The function filepath.Ext can be used for this purpose which seems to have a proper extension definition.

yogeshdnumb · 2023-04-15T07:12:02Z

I think this is a better solution

map A rename # at the very end
map c push A # new rename
map I push A # at the very beginning
map i push A # before extension
map a push A # after extension

I got this from lukesmith's voidrice config

joelim-work · 2023-06-24T04:47:15Z

I have updated the tips to reflect the new behavior of the rename command.

doronbehar · 2023-06-24T11:10:43Z

I have updated the tips to reflect the new behavior of the rename command.

What is the new behavior you are talking about exactly? Speaking of the wiki, that wiki section is very unclear TBH :). I think the previous version was better - It's not clear what is the purpose of showing that table - keybindings after / before applying your config? Also, what happened to the map ra and map re mappings? How does the example config there is implementing them?

Link to wiki diff: https://github.com/gokcehan/lf/wiki/Tips/_compare/8311fe2f2d0fef74cbd1baf858dbac44d0f4c865...12982d7d605d108e2bdd1a2fa35037f890fad631

joelim-work · 2023-06-24T14:53:28Z

What is the new behavior you are talking about exactly?

rename places the cursor at the extension by default as of #1162 so the map re mapping isn't needed anymore.

Speaking of the wiki, that wiki section is very unclear TBH :)

I agree that the descriptions by themselves can be vague, I have added another column to the table to visually show the effects of each mapping. Thanks for the feedback.

I think the previous version was better

I fail to see how. Positioning the cursor can be implemented entirely using native lf commands, so why involve shell scripting and the complexity it brings?

It's not clear what is the purpose of showing that table - keybindings after / before applying your config?

After. That is rather obvious when comparing the table with the mappings below.

Also, what happened to the map ra and map re mappings? How does the example config there is implementing them?

As I have explained above, map re is the default behavior already. map ra has the same effect as A in the new example.

doronbehar · 2023-06-24T21:34:34Z

Thanks for the link to the PR, I missed that. The table indeed looks better now. I still felt that the phrasings around the table and the config example was a bit confusing, so I expanded that a bit.

joelim-work · 2023-06-25T00:04:42Z

OK, thanks for tidying the example up. I think it looks even better now that the mapping table comes after the config.

@gokcehan Unless I'm missing something I believe this ticket can actually be closed now, since preserving the extension is now the default behavior.

gokcehan added the question label Jan 10, 2020

roket1428 mentioned this issue Mar 15, 2020

Make :rename accept multiple arguments as 1 file name #306

Closed

gokcehan added enhancement and removed question labels Mar 18, 2020

gokcehan mentioned this issue Jul 6, 2020

Automatically place cursor before last dot when renaming file #401

Closed

gokcehan mentioned this issue Mar 20, 2023

Enhance rename prompt #1162

Merged

gokcehan closed this as completed Jul 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename To Preserve Extension #279

Rename To Preserve Extension #279

smhmd commented Dec 25, 2019

lucas-mior commented Dec 27, 2019 •

edited

Loading

roket1428 commented Dec 30, 2019

Limero commented Jan 3, 2020

smhmd commented Jan 3, 2020

roket1428 commented Jan 3, 2020

gokcehan commented Jan 10, 2020

smhmd commented Jan 10, 2020 •

edited

Loading

roket1428 commented Feb 9, 2020 •

edited

Loading

doronbehar commented Mar 13, 2020

roket1428 commented Mar 14, 2020

doronbehar commented Mar 14, 2020

gokcehan commented Mar 18, 2020

yogeshdnumb commented Apr 15, 2023 •

edited

Loading

joelim-work commented Jun 24, 2023

doronbehar commented Jun 24, 2023

joelim-work commented Jun 24, 2023

doronbehar commented Jun 24, 2023

joelim-work commented Jun 25, 2023

Rename To Preserve Extension #279

Rename To Preserve Extension #279

Comments

smhmd commented Dec 25, 2019

lucas-mior commented Dec 27, 2019 • edited Loading

roket1428 commented Dec 30, 2019

Limero commented Jan 3, 2020

smhmd commented Jan 3, 2020

roket1428 commented Jan 3, 2020

gokcehan commented Jan 10, 2020

smhmd commented Jan 10, 2020 • edited Loading

roket1428 commented Feb 9, 2020 • edited Loading

doronbehar commented Mar 13, 2020

roket1428 commented Mar 14, 2020

doronbehar commented Mar 14, 2020

gokcehan commented Mar 18, 2020

yogeshdnumb commented Apr 15, 2023 • edited Loading

joelim-work commented Jun 24, 2023

doronbehar commented Jun 24, 2023

joelim-work commented Jun 24, 2023

doronbehar commented Jun 24, 2023

joelim-work commented Jun 25, 2023

lucas-mior commented Dec 27, 2019 •

edited

Loading

smhmd commented Jan 10, 2020 •

edited

Loading

roket1428 commented Feb 9, 2020 •

edited

Loading

yogeshdnumb commented Apr 15, 2023 •

edited

Loading