-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go1.18 Support #381
Comments
BTW |
For reference, a project that make extensive use of 1.18 generics: https://goreportcard.com/report/github.com/goradd/maps gofmt chokes on it. golint, not too bad. Everything else is fine. |
Maybe switch or conditionally switch to staticcheck? golang/go#38968 (comment) There's also golangci-lint which has support for many linters including staticcheck. |
Hello, GRC is now running on Go 1.18, and the golint check has been removed. |
golint has been replaced with go vet, which is not nearly as robust as golint. The golint repo recommends Staticcheck as a replacement. Why not use that? |
@spekary just to clarify we were already running go vet, it didn't replace golint. We can certainly take a look at running staticcheck. |
Actually, a better system might be to use https://golangci-lint.run. It might make go report card more flexible. It already includes running many of the checks here on go report card. It also makes it easy to turn particular linters on and off so that goreportcard can be more easily modified in the future. Over at awesome-go we have been using goreportcard as one of the validations of code quality. However, now that goreportcard no longer uses go lint, its not as useful. Hopefully you guys can find another linter to work with? |
Many tools are not able to handle Go1.18 yet. Upgrading
gofmt
should be fairly easy, butgolint
orineffassign
could be problematic.The text was updated successfully, but these errors were encountered: