Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go1.18 Support #381

Open
lmittmann opened this issue Mar 15, 2022 · 7 comments
Open

Go1.18 Support #381

lmittmann opened this issue Mar 15, 2022 · 7 comments

Comments

@lmittmann
Copy link

Many tools are not able to handle Go1.18 yet. Upgrading gofmt should be fairly easy, but golint or ineffassign could be problematic.

@peczenyj
Copy link

BTW
#378 (comment)

@spekary
Copy link

spekary commented Mar 21, 2022

For reference, a project that make extensive use of 1.18 generics:

https://goreportcard.com/report/github.com/goradd/maps

gofmt chokes on it. golint, not too bad. Everything else is fine.

@phanirithvij
Copy link

phanirithvij commented Mar 22, 2022

Maybe switch or conditionally switch to staticcheck? golang/go#38968 (comment)

There's also golangci-lint which has support for many linters including staticcheck.

@shawnps
Copy link
Contributor

shawnps commented Mar 22, 2022

Hello, GRC is now running on Go 1.18, and the golint check has been removed.

@spekary
Copy link

spekary commented Mar 22, 2022

golint has been replaced with go vet, which is not nearly as robust as golint. The golint repo recommends Staticcheck as a replacement. Why not use that?

@shawnps
Copy link
Contributor

shawnps commented Mar 23, 2022

@spekary just to clarify we were already running go vet, it didn't replace golint.

We can certainly take a look at running staticcheck.

@spekary
Copy link

spekary commented Mar 31, 2022

Actually, a better system might be to use https://golangci-lint.run.

It might make go report card more flexible. It already includes running many of the checks here on go report card. It also makes it easy to turn particular linters on and off so that goreportcard can be more easily modified in the future.

Over at awesome-go we have been using goreportcard as one of the validations of code quality. However, now that goreportcard no longer uses go lint, its not as useful. Hopefully you guys can find another linter to work with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants