Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

New theme: Hamburg #424

Closed
10 tasks done
hauke96 opened this issue Sep 10, 2018 · 4 comments
Closed
10 tasks done

New theme: Hamburg #424

hauke96 opened this issue Sep 10, 2018 · 4 comments

Comments

@hauke96
Copy link

hauke96 commented Sep 10, 2018

Theme submission

Before submitting a theme please make sure you've read the README.md. It describes in detail what information are needed and which requirements have to be fulfilled for the submission. The check list below can help you.

Link to my theme repository: https://github.com/hauke96/hugo-theme-hamburg

I made sure that...

  • the repository contains a good README.md describing my theme
  • an open source license has been added to LICENSE.md
  • all metadata have been added to theme.toml
  • screenshots have been added in the images/ folder with the required dimensions
  • in case I'm using a customized demo via the exampleSite folder that
    • https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
    • the site's content is as neutral as possible (contains no ads etc.) and reflects the features of my theme
  • I tested my theme against the gohugoio/HugoBasicExample
    • I've checked the developer tools' console in my browser for error messages
  • in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

Feel free to ask questions. We're glad to help.

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Sep 14, 2018

@hauke96

Thanks for your submission!

First of all I understand that your theme has among others the following important new features compared to the original Vienna Theme:

  • multilingual support
  • menu
  • multiple authors
  • pages

When I execute the Hugo Themes Site Build Script your Demo generates fine. 👍

However:

  • You need to remove the /public/ and /resources/ folders under your Example Site. Your theme does not use Hugo resources as far as I can tell and also there is no need for the contents of the public folder.
  • You theme visually looks almost identical identical to the original Vienna theme. At the very least please consider changing the banner. For instance use an open source photo of Hamburg or something else.
  • I am not a big fan of your avatar. In the README we request that the content of Example Sites is kept as neutral as possible. Religious iconography is not neutral in my book. Would you please consider using something else?

Also I am tagging @digitalcraftsman because I would like him to voice his opinion about the issues I raised.

@hauke96
Copy link
Author

hauke96 commented Sep 20, 2018

Hi @onedrawingperday ,

thanks for the review. I changed the theme (or better the example site) and now it hopefully fits the requirements.

@onedrawingperday
Copy link
Contributor

@hauke96
Thank you for making the changes! 👍

The new Example Site renders fine on my end.

@digitalcraftsman This theme looks ready to be added to the website.

@digitalcraftsman
Copy link
Member

Moin Hauke,

thank you for sharing this theme with us. I've added your theme and it should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants