driver/pgsql: optimize regex for version matching (#3583)

yincongcyincong · web-flow · commit 15b60462a2c7 · 2024-05-21T21:51:43.000+08:00
diff --git a/contrib/drivers/pgsql/pgsql_tables.go b/contrib/drivers/pgsql/pgsql_tables.go
@@ -32,6 +32,8 @@ WHERE
 ORDER BY
 	c.relname
 `
+
+	versionRegex = regexp.MustCompile(`PostgreSQL (\d+\.\d+)`)
 )
 
 func init() {
@@ -90,7 +92,7 @@ func (d *Driver) version(ctx context.Context, link gdb.Link) string {
 	}
 	if len(result) > 0 {
 		if v, ok := result[0]["version"]; ok {
-			matches := regexp.MustCompile(`PostgreSQL (\d+\.\d+)`).FindStringSubmatch(v.String())
+			matches := versionRegex.FindStringSubmatch(v.String())
 			if len(matches) >= 2 {
 				return matches[1]
 			}

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,8 @@ WHERE`
`32`	`32`	`ORDER BY`
`33`	`33`	`c.relname`
`34`	`34`	`
	`35`	`+`
	`36`	+ versionRegex = regexp.MustCompile(`PostgreSQL (\d+\.\d+)`)
`35`	`37`	`)`
`36`	`38`
`37`	`39`	`func init() {`
`@@ -90,7 +92,7 @@ func (d *Driver) version(ctx context.Context, link gdb.Link) string {`
`90`	`92`	`}`
`91`	`93`	`if len(result) > 0 {`
`92`	`94`	`if v, ok := result[0]["version"]; ok {`
`93`		- matches := regexp.MustCompile(`PostgreSQL (\d+\.\d+)`).FindStringSubmatch(v.String())
	`95`	`+ matches := versionRegex.FindStringSubmatch(v.String())`
`94`	`96`	`if len(matches) >= 2 {`
`95`	`97`	`return matches[1]`
`96`	`98`	`}`