Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported games being marked as spam #72

Open
massimilianodelliubaldini opened this issue Sep 29, 2019 · 13 comments
Open

Imported games being marked as spam #72

massimilianodelliubaldini opened this issue Sep 29, 2019 · 13 comments

Comments

@massimilianodelliubaldini

I have had a couple of users report that they don't see some of their games in Galaxy, including myself. When I check this URL with the Game ID in question, I see that the game type had been marked as spam.

Could it be that I'm doing something wrong during the import process, thus causing the game to be marked as spam, or is this a protection measure in Galaxy itself that is unrelated to plugins?

@apawlowskij
Copy link
Contributor

Your plugin is fine. This is an automatic mechanism preventing users from spamming the database with invalid data. I would kindly ask you to specify which games (game id would be enough) exactly are marked, so we can fix them.

@TBemme
Copy link

TBemme commented Sep 30, 2019

So there is nothing we can do to prevent this happening? This happened to some of my games as well (seemingly random, there was no common thing about them I can think of, and each plugin was only sending a small amount of games, less than 20 each)

Edit: The reason I would prefer to prevent this from happening is because firstly, it took a long time to get one of my games fixed (almost 3 weeks after reporting it. The next one took less time, so maybe the first was just unlucky) and I could not do anything about it myself because Galaxy was using this data to make it invisible in my Library. Ideally I would like to be able to fix it myself, I am only adding games that I want to have in there to my Library.

And my second concern is, I had one game disappear after some time of already being in my Library just fine. I only noticed it because that integration was for a very small number of games, and one going missing suddenly was very noticable. There could be some other games missing from larger integrations that I do not know about. I do not like having to worry about manually counting my Library all the time just to make sure everything is there and Galaxy hasn't randomly hidden something.

@massimilianodelliubaldini
Copy link
Author

@apaulouski Thanks for the info. The two games I personally saw this happen to couldn't properly find their Release Dates, so Galaxy displayed this as "Invalid Date ()". That may be a potential reason they got flagged.

Here's a list of the games that I know had this problem.

NPUA80643
BLUS30377
BLES01481
BLUS31604

I hope this information helps improve the algorithm for handling invalid user data. If there's anything we as plugin developers should be doing to mitigate the chance that it happens, please let us know. Thanks!

@Mixaill
Copy link
Contributor

Mixaill commented Sep 30, 2019

The same problem
https://mantis2.gog.com/view.php?id=13100

wargaming/STD2.WW.PRODUCTION

@apawlowskij
Copy link
Contributor

Plugin developers only need to return proper game name and ID for a specific platform, rest will be taken care of by the GLX, like matching the same games from different packs, platforms, editions. This is mostly automatic, but in rare cases requires some manual intervention, e.g. a game might fall under the "spam" category and should resolved manually, yet this is a one-time thing for a game and doesn't require anything from the user or plugin developer, so should no be a problem. We will do our best to improve this process in future.

Any games missing in the GLX should be reported via GLX client -> cogwheel menu -> Report Issue. Usually it doesn't take much time to fix them.

@mpm11011 @Mixaill I've passed this info to the responsible person, so hope it gets fixed soon. Sorry for the inconvenience caused.

@massimilianodelliubaldini
Copy link
Author

@apaulouski Thanks for looking into this for us!

@lele-blue
Copy link

Some users of my itch.io integration have reported about many to all of their games vanishing from gog over time, could this be due to them being marked as spam, and if yes, is there anything I can change with my integration to prevent this from happening?

@apawlowskij
Copy link
Contributor

@Ertego missing games are unmatched in our DB, those not visible for the users. We're working on it, and they should be back soon.
Once they're matched, they should not disappear over the time. If this is happening, I'd like to request IDs/names of these games so we can investigate it further.
Unfortunately, there is nothing you could do yet to prevent this. We hope to improve this over the time. I'm sorry for the inconvenience this caused.

@RKJokela
Copy link

How do I go about finding the game_id for a given game? For example if I'm making a simple integration to add some SNES games, what do I use to add e.g. Super Metroid? It shows up in the global search in the client, but if I try to add it with add_game in my plugin it doesn't work.

@lele-blue
Copy link

lele-blue commented Oct 16, 2019

@apaulouski
The games reported missing are
Arc Symphony, Depression Quest, Escaped Chasm, Eventual Pong, Fortune-499, Geek Remix Presents: Pairanormal, Gender Prison, Heaven Will Be Mine, It Will Be Hard, Keep It Together, Kimmy, Localhost, Milkmaid of the Milky Way, Minit, Panoramical, PUNKS - A 2064 Sidestory, simmiland, Social Justice Warriors, Subserial Network, The Tearoom, TOUCH MELBOURNE, VA-11 Hall-A KIDS!, Wheels of Aurelia, zFRAG, Gacha Life PC, dwarf fortress and The path
Also some of them aren't games but tools:
GoDot Engine, Deff, Multi-Platform Arcade Game Designer

However due to the nature of itch being a platform where everyone can upload their indie games there are much more games that will be hidden as soon as someone installs them :/

@Mixaill
Copy link
Contributor

Mixaill commented Oct 16, 2019

Maybe there is a way to provide a list of all the possible game identifiers, as it was done with integrations?

Mixaill/galaxy-integration-gw2#4 (comment)

@apawlowskij
Copy link
Contributor

@Ertego currently all unmatched itch.io games are "frozen". Most of them lack description and pictures/icons, or their resolution is too small.
There is ~1k of such games, so updating them manually is not an option. We're working on a tool that should help us fulfill missing data, but I don't have any ETA for you.
@Mixaill game IDs and titles are already provided by the plugins, yet we're lacking games description, covers, icons, screenshots e.t.c. Otherwise you'd see empty games in the GLX, and that's not something we're aiming for.
Sorry for inconvenience.

@Mixaill
Copy link
Contributor

Mixaill commented Oct 21, 2019

@apaulouski I mean, verified integration maintainer could provide to GOG link to the up-to-date JSON with extended info about available games, like:

{
    "games": [
        {
            "release_per_platform_id": "{platform_id}_{game_id}",
            "other_platforms": [
                "{platform_id_2}_{game_id_2}",
                "{platform_id_3}_{game_id_3}"
            ],
            "is_dlc": false,
            "dlcs": [
                "{platform_id_4}_{game_id_5}",
                "{platform_id_5}_{game_id_5}"
            ],
            "name": {
                "*": "Game Title",
                "pl-PL": "Nazwa gry"
            },
            "supported_os" : 
            [
                "Windows",
                "macOS",
                "Linux"
            ],
            "available_languages": [
                {
                    "code": "en-US",
                    "voiceover": true,
                    "subtitles": true
                }
            ],
            "summary": {
                "*": "Game Description",
                "pl-PL": "Opis gry"
            },
            "videos": [
                {
                    "name": "Trailer",
                    "url": "https://www.youtube.com/watch?v=dQw4w9WgXcQ"
                }
            ],
            "artwork": {
                "cover": "https://i.imgur.com/13DiGdu.png"
            },
            "achievements": [
                {
                    "api_key": "{achievement_id}",
                    "name" : {
                        "*": "Achievement Name"
                    },
                    "description" : {
                        "*": "Achievement Description"
                    },
                    "image_url_locked": "https://gw2.friends-of-friends-of-galaxy.org/assets/achievement-unearned.png",     
                    "image_url_unlocked": "https://gw2.friends-of-friends-of-galaxy.org/assets/achievement-earned.png"
                }
            ]
        }
    ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants