-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤗 [Question]: clarification re. unsafe and Go incompatibility #2304
Comments
Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
to 1. we left out the intermediate versions to keep the workflow faster to 2. but we always have to meet the basic requirement of 1.16 with the code, i.e. if a feature is added later, it can't be used or has to be adjusted by magic anotations in the golang file so that it is only used for that version what you mentioned has only to do with the fact that the new version then has not yet been tested in our ci to 3. also i can not remember any changes in the unsafe package |
This data point is quite useful. @ReneWerner87 Many thanks for the detailed explanation. Closing this issue accordingly. |
Question Description
Thank you for this project! We're evaluating if we should adopt fibre, so I have some corresponding questions:
Quoted from Limitations stated in README:
go-version
intest.yml
the supported Go versions (not sure why 1.18 is missing)? In other words, Since Fiberv2.41.0
is out, just like v2.40.0, it also supports Go versions 1.16 to 1.19.1.
, to support a new Go version, a PR is created to add the new version totest.yml
(e.g., ci: add go 1.19 to tests #1994), andthe library may not always be compatible with the latest Go version
refers to the time difference between a Go version is released and a corresponding update PR is merged and then a release is cut on Fiber side. Just want to confirm it's just a timing thing instead of the possibility that a future major Go version won't be ever supported by Fiber.2.
is applicable to any library (i.e., all libraries have to update their CI to support a new Go version, and that takes some time), I'm wondering how Fiber's usage ofunsafe
makes the process harder. From Go 1 Compatibility doc, it says "Use of package unsafe. Packages that import unsafe may depend on internal properties of the Go implementation. We reserve the right to make changes to the implementation that may break such programs.", and since a new Go version may contain breaking changes to theunsafe
package, it may take some effort for Fiber to support the new version, but Fiber will still support it, just that it may come a bit slower. Sort of coming back to the conclusion of2.
, but I just want to confirm, thanks!Code Snippet (optional)
No response
Checklist:
The text was updated successfully, but these errors were encountered: