Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤗 [Problem]: tls.Config in ListenTLS #2025

Closed
3 tasks done
ja3abuser opened this issue Aug 19, 2022 · 4 comments · Fixed by #2034
Closed
3 tasks done

🤗 [Problem]: tls.Config in ListenTLS #2025

ja3abuser opened this issue Aug 19, 2022 · 4 comments · Fixed by #2034

Comments

@ja3abuser
Copy link

Question Description

Can do you, please, set NextProto: []string{"h2"} in tls.Config of ListenTLS?
Without that I can't use dgrr/http2 :(

Fiber version is v2.37.0-rc.1

Code Snippet (optional)

package main

import "github.com/gofiber/fiber/v2"
import "log"

func main() {
  app := fiber.New()

  http2.ConfigureServer(app.Server(), http2.ServerConfig{})

  log.Fatal(app.ListenTLS(":3000", ...))
}

Checklist:

  • I agree to follow Fiber's Code of Conduct.
  • I have checked for existing issues that describe my questions prior to opening this one.
  • I understand that improperly formatted questions may be closed without explanation.
@welcome
Copy link

welcome bot commented Aug 19, 2022

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@efectn
Copy link
Member

efectn commented Aug 19, 2022

I think we don't need it because of Fiber doesn't have default HTTP/2 support. You can use Listener to pass custom TLS config.

@ja3abuser
Copy link
Author

I think we don't need it because of Fiber doesn't have default HTTP/2 support. You can use Listener to pass custom TLS config.

In my opinion, this might kill the ClientHelloInfo feature, because I don't have access to the non-exported fields in fiber.

@efectn
Copy link
Member

efectn commented Aug 19, 2022

Author

Right. We may need to get TLS from https://github.com/gofiber/fiber/blob/master/listen.go#L31 and pass it to CHI to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants