♻ Refactor: Change app.Test() and all uses to accept 0 as no timeout instead of -1

Author: grivera64

Diff for: app.go

@@ -919,7 +919,7 @@ type TestConfig struct {
 
 // Test is used for internal debugging by passing a *http.Request.
 // Config is optional and defaults to a 1s error on timeout,
-// -1 timeout will disable it completely.
+// 0 timeout will disable it completely.
 func (app *App) Test(req *http.Request, config ...TestConfig) (*http.Response, error) {
 	// Default config
 	cfg := TestConfig{
@@ -968,7 +968,7 @@ func (app *App) Test(req *http.Request, config ...TestConfig) (*http.Response, e
 	}()
 
 	// Wait for callback
-	if cfg.Timeout >= 0 {
+	if cfg.Timeout > 0 {
 		// With timeout
 		select {
 		case err = <-channel:

Diff for: app_test.go

@@ -1126,8 +1126,7 @@ func Test_Test_Timeout(t *testing.T) {
 	app.Get("/", testEmptyHandler)
 
 	resp, err := app.Test(httptest.NewRequest(MethodGet, "/", nil), TestConfig{
-		Timeout:       -1,
-		FailOnTimeout: false,
+		Timeout: 0,
 	})
 	require.NoError(t, err, "app.Test(req)")
 	require.Equal(t, 200, resp.StatusCode, "Status code")
@@ -1440,8 +1439,7 @@ func Test_App_Test_no_timeout_infinitely(t *testing.T) {
 
 		req := httptest.NewRequest(MethodGet, "/", nil)
 		_, err = app.Test(req, TestConfig{
-			Timeout:       -1,
-			FailOnTimeout: true,
+			Timeout: 0,
 		})
 	}()
 

Diff for: docs/api/app.md

@@ -641,7 +641,7 @@ func (app *App) SetTLSHandler(tlsHandler *TLSHandler)
 
 ## Test
 
-Testing your application is done with the `Test` method. Use this method for creating `_test.go` files or when you need to debug your routing logic. The default timeout is `1s`; to disable a timeout altogether, pass a `TestConfig` struct with `Timeout: -1`.
+Testing your application is done with the `Test` method. Use this method for creating `_test.go` files or when you need to debug your routing logic. The default timeout is `1s`; to disable a timeout altogether, pass a `TestConfig` struct with `Timeout: 0`.
 
 ```go title="Signature"
 func (app *App) Test(req *http.Request, config ...TestConfig) (*http.Response, error)
@@ -706,8 +706,7 @@ cfg := fiber.TestConfig{
 }
 ```
 
-This would make a Test that instantly times out,
-which would always result in a "test: empty response" error.
+This would make a Test that has no timeout.
 
 :::
 

Diff for: docs/whats_new.md

@@ -76,6 +76,7 @@ We have made several changes to the Fiber app, including:
 ### Methods changes
 
 - Test -> Replaced timeout with a config parameter
+  - -1 represents no timeout -> 0 represents no timeout
 - Listen -> has a config parameter
 - Listener -> has a config parameter
 
@@ -201,7 +202,7 @@ app.Get("/", func(c fiber.Ctx) {
 // Define the HTTP request and custom TestConfig to test the handler
 req := httptest.NewRequest(MethodGet, "/", nil)
 testConfig := fiber.TestConfig{
-  Timeout:       -1,
+  Timeout:       0,
   FailOnTimeout: false,
 }
 

Diff for: middleware/keyauth/keyauth_test.go

@@ -15,8 +15,7 @@ import (
 const CorrectKey = "specials: !$%,.#\"!?~`<>@$^*(){}[]|/\\123"
 
 var testConfig = fiber.TestConfig{
-	Timeout:       -1,
-	FailOnTimeout: false,
+	Timeout: 0,
 }
 
 func Test_AuthSources(t *testing.T) {