From 66cf38ec7c1c536e1e35d45d3db88dbf707f5da1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Verschelde?= Date: Sat, 13 Apr 2024 10:22:44 +0200 Subject: [PATCH] Tests: Remove NavigationRegion3D race condition that fails on CI As the comment pointed it out, it's a race condition, and evidently no, "it's [not] fine" ;) --- tests/scene/test_navigation_region_3d.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/tests/scene/test_navigation_region_3d.h b/tests/scene/test_navigation_region_3d.h index 372f6dc50575..fa4ac2738dc4 100644 --- a/tests/scene/test_navigation_region_3d.h +++ b/tests/scene/test_navigation_region_3d.h @@ -71,15 +71,6 @@ TEST_SUITE("[Navigation]") { CHECK_NE(navigation_mesh->get_vertices().size(), 0); } - // Race condition is present in the below subcase, but baking should take many - // orders of magnitude longer than basic checks on the main thread, so it's fine. - SUBCASE("Asynchronous bake should not be immediate") { - navigation_region->bake_navigation_mesh(true); - CHECK(navigation_region->is_baking()); - CHECK_EQ(navigation_mesh->get_polygon_count(), 0); - CHECK_EQ(navigation_mesh->get_vertices().size(), 0); - } - memdelete(mesh_instance); memdelete(navigation_region); memdelete(node_3d);