Re-add support for installing templates from TPZ#118649
Merged
Merged
Conversation
Contributor
|
Hello I know this is an enhancement and we entered feature freeze, but I would like to vote in favour of merging it anyway because not being able to install from file (and always being forced to download from the web) is a massive, massive usability regression, and would also likely cause an avoidable strain on the servers. |
akien-mga
approved these changes
Apr 19, 2026
Member
akien-mga
left a comment
akien-mga
left a comment
There was a problem hiding this comment.
Only reviewing quickly on the phone: I suppose that the amount of code added to re-introduce this feature just means that this code had been fully removed previously?
Member
Author
|
Yes, this only re-adds old method, with some minor changes. |
Contributor
|
Needs rebase |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #117072
The button works the same as before, i.e. open file dialog, you select file, templates get installed.