Skip to content

Conversation

@passivestar
Copy link
Contributor

Fixes broken icons in the light mode of the new theme

Closes #112254, supersedes #112265, cc @YeldhamDev

Master PR
3 4
1 2

@passivestar passivestar requested review from a team as code owners November 1, 2025 10:00
@Chaosus Chaosus added this to the 4.6 milestone Nov 1, 2025
@YeldhamDev
Copy link
Member

YeldhamDev commented Nov 1, 2025

The accent color for toggled buttons is still very dark:

image

@passivestar
Copy link
Contributor Author

The accent color for toggled buttons is still very dark

Fixed

image

@YeldhamDev
Copy link
Member

The output icons now have the accent when they shouldn't:

Screenshot_20251101_080644

@passivestar
Copy link
Contributor Author

passivestar commented Nov 1, 2025

The output icons now have the accent when they shouldn't

Comments about those needing special styling were copied from the classic theme but not the actual code. Fixed.

image

Also checked the bottom panel indicators to make sure they have it. Those do have it so no changes are needed there:

// Don't tint the icon even when in "pressed" state.
p_theme->set_color("icon_pressed_color", "BottomPanelButton", Color(1, 1, 1, 1));
Color icon_hover_color = p_config.icon_normal_color * (p_config.dark_icon_and_font ? 1.15 : 1.0);
icon_hover_color.a = 1.0;
p_theme->set_color("icon_hover_color", "BottomPanelButton", icon_hover_color);
p_theme->set_color("icon_hover_pressed_color", "BottomPanelButton", icon_hover_color);

@akien-mga akien-mga merged commit 66d2d9a into godotengine:master Nov 1, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@passivestar passivestar deleted the light-mode-icons branch November 1, 2025 19:42
passivestar added a commit to passivestar/godot-minimal-theme that referenced this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Godot logo in Project manager has flatten look on light modern theme

4 participants