Skip to content

Fix un-init base path when switch AnimationNode in BlendSpace2D#112050

Closed
xuhuisheng wants to merge 1 commit into
godotengine:masterfrom
xuhuisheng:dev/anim_warning
Closed

Fix un-init base path when switch AnimationNode in BlendSpace2D#112050
xuhuisheng wants to merge 1 commit into
godotengine:masterfrom
xuhuisheng:dev/anim_warning

Conversation

@xuhuisheng
Copy link
Copy Markdown
Contributor

@xuhuisheng xuhuisheng commented Oct 26, 2025

Issue Description

When we move position in BlenderSpace2D with capture, it will try to copy backward property from current_animation to new_animation when switch animation.

E 0:00:04:817   set_parameter: Condition "!process_state->tree->property_parent_map.has(node_state.base_path)" is true.
  <Origem C++>  scene/animation/animation_tree.cpp:84 @ set_parameter()

That caused by new_animation hasnot init base_path.

Solution

This patch inited base_path for new_animation.

@PavielKraskouski
Copy link
Copy Markdown
Contributor

Errors also occur in BlendSpace1D. This needs to be fixed as well.

@PavielKraskouski
Copy link
Copy Markdown
Contributor

Opened #112053 for this PR.

@xuhuisheng
Copy link
Copy Markdown
Contributor Author

@PavielKraskouski

Thanks for the reminder. Added 'AnimationBlendSpace1D' as well.

@AThousandShips AThousandShips added this to the 4.6 milestone Oct 27, 2025
@TokageItLab
Copy link
Copy Markdown
Member

I wonder if setting node_state_base_path in the subclass is the correct approach.
The issue will probably be resolved by #112308 guarantee of process_state, then this PR is superseded with that.

@TokageItLab TokageItLab moved this from Ready for review to Pending, No consensus in Animation Team Issue Triage Nov 9, 2025
@Repiteo Repiteo modified the milestones: 4.6, 4.x Jan 26, 2026
@github-project-automation github-project-automation Bot moved this from Pending, No consensus to Done in Animation Team Issue Triage Mar 14, 2026
@akien-mga akien-mga modified the milestones: 4.x, 4.7 Mar 14, 2026
@xuhuisheng xuhuisheng deleted the dev/anim_warning branch March 14, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Errors when switching animations while in Capture blend mode in BlendSpace1D and BlendSpace2D

6 participants