Skip to content

Metal: Ensure correct output texture format selection #109406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Repiteo merged 1 commit into from
Aug 8, 2025
Merged

Metal: Ensure correct output texture format selection #109406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion servers/rendering/renderer_rd/storage_rd/render_scene_buffers_rd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,11 +255,20 @@ void RenderSceneBuffersRD::ensure_mfx(RendererRD::MFXSpatialEffect *p_effect) {
if (mfx_spatial_context) {
return;
}

RendererRD::TextureStorage *texture_storage = RendererRD::TextureStorage::get_singleton();
RenderingDevice *rd = RD::get_singleton();

// Determine the output format of the render target.
RID dest = texture_storage->render_target_get_rd_texture(render_target);
RD::TextureFormat tf = rd->texture_get_format(dest);
RD::DataFormat output_format = tf.format;

RendererRD::MFXSpatialEffect::CreateParams params = {
.input_size = internal_size,
.output_size = target_size,
.input_format = base_data_format,
.output_format = RD::DATA_FORMAT_R8G8B8A8_UNORM,
.output_format = output_format,
};

mfx_spatial_context = p_effect->create_context(params);
Expand Down
1 change: 1 addition & 0 deletions servers/rendering/renderer_viewport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1352,6 +1352,7 @@ void RendererViewport::viewport_set_use_hdr_2d(RID p_viewport, bool p_use_hdr_2d
}
viewport->use_hdr_2d = p_use_hdr_2d;
RSG::texture_storage->render_target_set_use_hdr(viewport->render_target, p_use_hdr_2d);
_configure_3d_render_buffers(viewport);
}

bool RendererViewport::viewport_is_using_hdr_2d(RID p_viewport) const {
Expand Down
Loading