Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add problem matcher for Godot, fail tests if triggered #100964

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Dec 31, 2024

There's been quite a lot of additions to tests lately that absolutely explode the CI output with error messages. This attempts to be a twofold solution to the problem:

  • Add dedicated problem-matcher for Godot errors, so GHA can track them
  • Detect if any warnings/errors aren't properly suppressed & fail a --test operation if so

The former worked like a charm, and the latter mostly works, but there's still some discrepancies that need ironing out. Namely, figuring out where exactly errors are accumulating when outputs are supposed to be suppressed. This might come down to how there's a shocking amount of places where print functionality can be toggled, causing weird overlaps. But the core of the functionality is in place: CI will not pass if warning/error output is not properly suppressed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant