Core: Cleanup Array/Dictionary implementation #100953
Open
+161
−178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of fixes/improvements for Arrays & Dictionaries, particularly the typed variants. In no particular order:
std::initializer_list
support onTypedDictionary
by adding a few missing declarations & ensuring thatObject
types are passed as pointers.std::initializer_list
support forArray
/TypedArray
along with dedicated tests.Variant
conversion logic fromTypedArray
/TypedDictionary
toVariant
via forward-declared templates.typed_array.h
specialization macros into one, much liketyped_dictionary.h
.ArrayPrivate
/DictionaryPrivate
; they're now nested within their respective base classes.