Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Cleanup Array/Dictionary implementation #100953

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Dec 30, 2024

A collection of fixes/improvements for Arrays & Dictionaries, particularly the typed variants. In no particular order:

  • Fixed std::initializer_list support on TypedDictionary by adding a few missing declarations & ensuring that Object types are passed as pointers.
  • Added std::initializer_list support for Array/TypedArray along with dedicated tests.
  • Moved Variant conversion logic from TypedArray/TypedDictionary to Variant via forward-declared templates.
  • Consolidated typed_array.h specialization macros into one, much like typed_dictionary.h.
  • Migrated ArrayPrivate/DictionaryPrivate; they're now nested within their respective base classes.

@Repiteo Repiteo added this to the 4.4 milestone Dec 30, 2024
@Repiteo Repiteo requested review from a team as code owners December 30, 2024 20:29
@Repiteo Repiteo force-pushed the core/array-dict-cleanup branch 3 times, most recently from f49356e to 876b0b0 Compare December 30, 2024 20:47
@Repiteo Repiteo force-pushed the core/array-dict-cleanup branch from 876b0b0 to de9841b Compare December 30, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant