Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort methods to PoolStringArray #1439

Closed
me2beats opened this issue Aug 31, 2020 · 1 comment
Closed

Add sort methods to PoolStringArray #1439

me2beats opened this issue Aug 31, 2020 · 1 comment
Milestone

Comments

@me2beats
Copy link

me2beats commented Aug 31, 2020

Describe the project you are working on:
gdscript plugins

Describe the problem or limitation you are having in your project:
There is sort() in Array, can't find it in PoolStringArray

Describe the feature / enhancement and how it helps to overcome the problem or limitation:
sort() method in PoolStringArray could sort the array alphabetically

Describe how your proposal will work, with code, pseudocode, mockups, and/or diagrams:

PoolStringArray(["b","a"]).sort()
-> a b

If this enhancement will not be used often, can it be worked around with a few lines of script?:
I think this is possible, but I do not find it logical since there's sort() methods in Arrays

Is there a reason why this should be core and not an add-on in the asset library?:
should be a core feature

@Calinou
Copy link
Member

Calinou commented Aug 31, 2020

This was added to the master branch in godotengine/godot#32144 already. It might be possible to remake that pull request for the 3.2 branch too.

@Calinou Calinou closed this as completed Aug 31, 2020
@Calinou Calinou added this to the 4.0 milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants