Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Need update create_instance_func because godot gdextension_interface.h upgrade #1567

Closed
pupil1337 opened this issue Aug 29, 2024 · 2 comments · Fixed by #1568
Closed
Labels
enhancement This is an enhancement on the current functionality

Comments

@pupil1337
Copy link
Contributor

pupil1337 commented Aug 29, 2024

Godot version

godot master branch

godot-cpp version

godot-cpp master branch

System information

windows 10, msvc, i7-9700

Issue description

Use deprecated=no build godot will has this problem, because gdextension_classdb_construct_object be marked deprecated.
Please update the new function.
(I didn't submit a PR because this upgrade maybe need modify memnew's postinitialize i can`t handle it.)

Steps to reproduce

  1. Build godot custom args use deprecated=no. (godot: scons target=editor dev_build=yes... deprecated=no)
  2. compile godot-cpp will successed.
  3. open godot editor will error because cant find gdextension_classdb_construct_object.

Minimal reproduction project

N/A

@dsnopek
Copy link
Collaborator

dsnopek commented Aug 29, 2024

Yep, it's on my TODO list!

Use deprecated=no build godot will has this problem, because gdextension_classdb_construct_object be marked deprecated.

If you're keeping up with Godot master and using deprecated=no, I suspect you will encounter this problem a few more times before Godot 4.4 is released. We can't always synchronize godot-cpp updates with Godot updates, even when we have a PR prepared in advance.

@dsnopek dsnopek added the enhancement This is an enhancement on the current functionality label Aug 29, 2024
@pupil1337
Copy link
Contributor Author

Yes, I switched to version 4.3 and everything is perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@dsnopek @pupil1337 and others