Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images do not load #104

Open
quozl opened this issue Nov 29, 2019 · 2 comments
Open

Images do not load #104

quozl opened this issue Nov 29, 2019 · 2 comments

Comments

@quozl
Copy link
Collaborator

quozl commented Nov 29, 2019

When the activity is built, bundled, installed, and then run, the embedded images are not shown.

  • make html copies the referenced images from images to html/_images
  • python setup.py dist_xo ignores the directory _images
  • the bundles does contain images but the HTML does not reference them

Discovered by accident as part of #99, and more information is in the comments of that pull request.

@godiard
Copy link
Owner

godiard commented Dec 2, 2019

I am not sure if this is the case, but looks like could be related to https://github.com/godiard/help-activity/blob/master/helpactivity.py#L129

@quozl
Copy link
Collaborator Author

quozl commented Dec 2, 2019

Thanks. Yes, it is related. When I add logging to the resource-load-started callback, I see the following;

  • when there is an html/_images directory (executed from a development directory), a call is made for each image loaded,,
  • when there is no html/_images directory (executed from unpacked bundle directory), no calls are made.

When I revert a1ee2c6, the problem goes away. So the cause appears to be a consequence of @chimosky's Port to WebKit2. I must have made a mistake in testing and should not have merged the pull request.

It is as if the signal is skipped for failed local filesystem access.

I've reviewed the C and Python bindings documentation for WebKitGTK, and can't find any promise that local filesystem requests can be redirected like this. Next steps are interactive debugging and reading the WebKitGTK source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants